pidgin/pidgin

Fix leaks in dynamic menus

15 months ago, Elliott Sales de Andrade
33ed4a2a7593
Fix leaks in dynamic menus

Fixes two leaks:
```
10,463 (48 direct, 10,415 indirect) bytes in 1 blocks are definitely lost in loss record 34,138 of 34,479
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x4980168: g_malloc (gmem.c:130)
by 0x4997AB5: g_slice_alloc (gslice.c:1074)
by 0x49980EC: g_slice_alloc0 (gslice.c:1100)
by 0x4DDF04B: g_type_create_instance (gtype.c:1913)
by 0x4DC4C1F: g_object_new_internal (gobject.c:2228)
by 0x4DC6247: g_object_new_with_properties (gobject.c:2391)
by 0x4DC6FF0: g_object_new (gobject.c:2037)
by 0x1CA978CF: purple_demo_protocol_get_menu (purpledemoprotocolactions.c:750)
by 0x4D2DB1F: purple_protocol_actions_get_menu (purpleprotocolactions.c:110)
by 0x489F74C: pidgin_accounts_enabled_menu_get_item_links (pidginaccountsenabledmenu.c:279)
by 0x5817C3F: g_menu_model_real_get_item_link (gmenumodel.c:397)
```
and
```
2,051 (144 direct, 1,907 indirect) bytes in 3 blocks are definitely lost in loss record 33,018 of 34,479
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x4980168: g_malloc (gmem.c:130)
by 0x4997AB5: g_slice_alloc (gslice.c:1074)
by 0x49980EC: g_slice_alloc0 (gslice.c:1100)
by 0x4DDF04B: g_type_create_instance (gtype.c:1913)
by 0x4DC4C1F: g_object_new_internal (gobject.c:2228)
by 0x4DC6247: g_object_new_with_properties (gobject.c:2391)
by 0x4DC6FF0: g_object_new (gobject.c:2037)
by 0x581E9EE: g_menu_item_new_section (gmenu.c:1256)
by 0x48B465F: pidgin_plugins_menu_get_item_links (pidginpluginsmenu.c:204)
by 0x5817C3F: g_menu_model_real_get_item_link (gmenumodel.c:397)
by 0x5124B78: gtk_menu_tracker_add_items (gtkmenutracker.c:313)
```

Testing Done:
Ran in `valgrind --leak-check=full` and confirmed that the leak was gone.

Reviewed at https://reviews.imfreedom.org/r/2298/
/*
* Purple - Internet Messaging Library
* Copyright (C) Pidgin Developers <devel@pidgin.im>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, see <https://www.gnu.org/licenses/>.
*/
#if !defined(PURPLE_GLOBAL_HEADER_INSIDE) && !defined(PURPLE_COMPILATION)
# error "only <purple.h> may be included directly"
#endif
#ifndef PURPLE_NOTIFICATION_MANAGER_H
#define PURPLE_NOTIFICATION_MANAGER_H
#include <glib.h>
#include <glib-object.h>
#include "account.h"
#include <purplenotification.h>
G_BEGIN_DECLS
#define PURPLE_TYPE_NOTIFICATION_MANAGER (purple_notification_manager_get_type())
G_DECLARE_FINAL_TYPE(PurpleNotificationManager, purple_notification_manager,
PURPLE, NOTIFICATION_MANAGER, GObject)
/**
* PurpleNotificationManager:
*
* Purple Notification Manager manages all notifications between protocols and
* plugins and how the user interface interacts with them.
*
* Since: 3.0.0
*/
/**
* purple_notification_manager_get_default:
*
* Gets the default [class@NotificationManager] instance.
*
* Returns: (transfer none): The default instance.
*
* Since: 3.0.0
*/
PurpleNotificationManager *purple_notification_manager_get_default(void);
/**
* purple_notification_manager_get_default_as_model:
*
* Gets the default manager instance type casted to [iface@Gio.ListModel].
*
* Returns: (transfer none): The model.
*
* Since: 3.0.0
*/
GListModel *purple_notification_manager_get_default_as_model(void);
/**
* purple_notification_manager_add:
* @manager: The instance.
* @notification: (transfer full): The [class@Notification] to add.
*
* Adds @notification into @manager.
*
* Since: 3.0.0
*/
void purple_notification_manager_add(PurpleNotificationManager *manager, PurpleNotification *notification);
/**
* purple_notification_manager_remove:
* @manager: The instance.
* @notification: The notification to remove.
*
* Removes @notification from @manager.
*
* Since: 3.0.0
*/
void purple_notification_manager_remove(PurpleNotificationManager *manager, PurpleNotification *notification);
/**
* purple_notification_manager_remove_with_account:
* @manager: The instance.
* @account: The [class@Account] whose notifications to remove.
* @all: Whether or not to clear connection error notifications as well.
*
* Removes all notifications with @account from @manager.
*
* If @all is set to %TRUE, notifications of type
* PURPLE_NOTIFICATION_TYPE_CONNECTION_ERROR will be removed as well. These are
* treated differently from other notifications tied to accounts, as those are
* transient and depend on the account being connected to be valid.
*
* Since: 3.0.0
*/
void purple_notification_manager_remove_with_account(PurpleNotificationManager *manager, PurpleAccount *account, gboolean all);
/**
* purple_notification_manager_get_unread_count:
* @manager: The instance.
*
* Gets the number of currently unread notifications.
*
* Returns: The number of unread notifications.
*
* Since: 3.0.0
*/
guint purple_notification_manager_get_unread_count(PurpleNotificationManager *manager);
/**
* purple_notification_manager_clear:
* @manager: The instance.
*
* Removes all notifications from @manager.
*
* Since: 3.0.0
*/
void purple_notification_manager_clear(PurpleNotificationManager *manager);
G_END_DECLS
#endif /* PURPLE_NOTIFICATION_MANAGER_H */