pidgin/pidgin

Fix leaks in dynamic menus

15 months ago, Elliott Sales de Andrade
33ed4a2a7593
Fix leaks in dynamic menus

Fixes two leaks:
```
10,463 (48 direct, 10,415 indirect) bytes in 1 blocks are definitely lost in loss record 34,138 of 34,479
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x4980168: g_malloc (gmem.c:130)
by 0x4997AB5: g_slice_alloc (gslice.c:1074)
by 0x49980EC: g_slice_alloc0 (gslice.c:1100)
by 0x4DDF04B: g_type_create_instance (gtype.c:1913)
by 0x4DC4C1F: g_object_new_internal (gobject.c:2228)
by 0x4DC6247: g_object_new_with_properties (gobject.c:2391)
by 0x4DC6FF0: g_object_new (gobject.c:2037)
by 0x1CA978CF: purple_demo_protocol_get_menu (purpledemoprotocolactions.c:750)
by 0x4D2DB1F: purple_protocol_actions_get_menu (purpleprotocolactions.c:110)
by 0x489F74C: pidgin_accounts_enabled_menu_get_item_links (pidginaccountsenabledmenu.c:279)
by 0x5817C3F: g_menu_model_real_get_item_link (gmenumodel.c:397)
```
and
```
2,051 (144 direct, 1,907 indirect) bytes in 3 blocks are definitely lost in loss record 33,018 of 34,479
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x4980168: g_malloc (gmem.c:130)
by 0x4997AB5: g_slice_alloc (gslice.c:1074)
by 0x49980EC: g_slice_alloc0 (gslice.c:1100)
by 0x4DDF04B: g_type_create_instance (gtype.c:1913)
by 0x4DC4C1F: g_object_new_internal (gobject.c:2228)
by 0x4DC6247: g_object_new_with_properties (gobject.c:2391)
by 0x4DC6FF0: g_object_new (gobject.c:2037)
by 0x581E9EE: g_menu_item_new_section (gmenu.c:1256)
by 0x48B465F: pidgin_plugins_menu_get_item_links (pidginpluginsmenu.c:204)
by 0x5817C3F: g_menu_model_real_get_item_link (gmenumodel.c:397)
by 0x5124B78: gtk_menu_tracker_add_items (gtkmenutracker.c:313)
```

Testing Done:
Ran in `valgrind --leak-check=full` and confirmed that the leak was gone.

Reviewed at https://reviews.imfreedom.org/r/2298/
/*
* Purple - Internet Messaging Library
* Copyright (C) Pidgin Developers <devel@pidgin.im>
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this library; if not, see <https://www.gnu.org/licenses/>.
*/
#if !defined(PURPLE_GLOBAL_HEADER_INSIDE) && !defined(PURPLE_COMPILATION)
# error "only <purple.h> may be included directly"
#endif
#ifndef PURPLE_HISTORY_ADAPTER_H
#define PURPLE_HISTORY_ADAPTER_H
#include <glib.h>
#include <glib-object.h>
#include <purplemessage.h>
#include <purpleconversation.h>
G_BEGIN_DECLS
/**
* PURPLE_HISTORY_ADAPTER_DOMAIN:
*
* A #GError domain for errors.
*
* Since: 3.0.0
*/
#define PURPLE_HISTORY_ADAPTER_DOMAIN (g_quark_from_static_string("purple-history-adapter"))
/**
* PurpleHistoryAdapter:
*
* #PurpleHistoryAdapter is a base class that should be sub classed by
* history adapters. It defines the behavior of all history adapters
* and implements some shared properties.
*
* Since: 3.0.0
*/
#define PURPLE_TYPE_HISTORY_ADAPTER (purple_history_adapter_get_type())
G_DECLARE_DERIVABLE_TYPE(PurpleHistoryAdapter, purple_history_adapter,
PURPLE, HISTORY_ADAPTER, GObject)
/**
* PurpleHistoryAdapterClass:
*
* #PurpleHistoryAdapterClass defines the interface for interacting with
* history adapters like sqlite, and so on.
*
* Since: 3.0.0
*/
struct _PurpleHistoryAdapterClass {
/*< private >*/
GObjectClass parent;
/*< public >*/
gboolean (*activate)(PurpleHistoryAdapter *adapter, GError **error);
gboolean (*deactivate)(PurpleHistoryAdapter *adapter, GError **error);
GList* (*query)(PurpleHistoryAdapter *adapter, const gchar *query, GError **error);
gboolean (*remove)(PurpleHistoryAdapter *adapter, const gchar *query, GError **error);
gboolean (*write)(PurpleHistoryAdapter *adapter, PurpleConversation *conversation, PurpleMessage *message, GError **error);
/*< private >*/
/* Some extra padding to play it safe. */
gpointer reserved[8];
};
/**
* purple_history_adapter_get_id:
* @adapter: The #PurpleHistoryAdapter instance.
*
* Gets the identifier of @adapter.
*
* Returns: The identifier of @adapter.
*
* Since: 3.0.0
*/
const gchar *purple_history_adapter_get_id(PurpleHistoryAdapter *adapter);
/**
* purple_history_adapter_get_name:
* @adapter: The #PurpleHistoryAdapter instance.
*
* Gets the name of @adapter.
*
* Returns: The name of @adapter.
*
* Since: 3.0.0
*/
const gchar *purple_history_adapter_get_name(PurpleHistoryAdapter *adapter);
/**
* purple_history_adapter_write:
* @adapter: The #PurpleHistoryAdapter instance.
* @conversation: The #PurpleConversation to send to the adapter.
* @message: The #PurpleMessage to send to the adapter.
* @error: A return address for a #GError.
*
* Writes a message to the @adapter.
*
* Returns: If the write was successful to the @adapter.
*
* Since: 3.0.0
*/
gboolean purple_history_adapter_write(PurpleHistoryAdapter *adapter,
PurpleConversation *conversation,
PurpleMessage *message,
GError **error);
/**
* purple_history_adapter_query:
* @adapter: The #PurpleHistoryAdapter instance.
* @query: The query to send to the @adapter.
* @error: A return address for a #GError.
*
* Runs @query against @adapter.
*
* Returns: (element-type PurpleMessage) (transfer container): A list of messages that match @query.
*
* Since: 3.0.0
*/
GList *purple_history_adapter_query(PurpleHistoryAdapter *adapter,
const gchar *query,
GError **error);
/**
* purple_history_adapter_remove:
* @adapter: The #PurpleHistoryAdapter instance.
* @query: Tells @adapter to remove messages that match @query.
* @error: A return address for a #GError.
*
* Tells @adapter to remove messages that match @query
*
* Returns: If removing the messages was successful.
*
* Since: 3.0.0
*/
gboolean purple_history_adapter_remove(PurpleHistoryAdapter *adapter,
const gchar *query,
GError **error);
G_END_DECLS
#endif /* PURPLE_HISTORY_ADAPTER */