pidgin/pidgin

Fix leaks in dynamic menus

15 months ago, Elliott Sales de Andrade
33ed4a2a7593
Fix leaks in dynamic menus

Fixes two leaks:
```
10,463 (48 direct, 10,415 indirect) bytes in 1 blocks are definitely lost in loss record 34,138 of 34,479
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x4980168: g_malloc (gmem.c:130)
by 0x4997AB5: g_slice_alloc (gslice.c:1074)
by 0x49980EC: g_slice_alloc0 (gslice.c:1100)
by 0x4DDF04B: g_type_create_instance (gtype.c:1913)
by 0x4DC4C1F: g_object_new_internal (gobject.c:2228)
by 0x4DC6247: g_object_new_with_properties (gobject.c:2391)
by 0x4DC6FF0: g_object_new (gobject.c:2037)
by 0x1CA978CF: purple_demo_protocol_get_menu (purpledemoprotocolactions.c:750)
by 0x4D2DB1F: purple_protocol_actions_get_menu (purpleprotocolactions.c:110)
by 0x489F74C: pidgin_accounts_enabled_menu_get_item_links (pidginaccountsenabledmenu.c:279)
by 0x5817C3F: g_menu_model_real_get_item_link (gmenumodel.c:397)
```
and
```
2,051 (144 direct, 1,907 indirect) bytes in 3 blocks are definitely lost in loss record 33,018 of 34,479
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x4980168: g_malloc (gmem.c:130)
by 0x4997AB5: g_slice_alloc (gslice.c:1074)
by 0x49980EC: g_slice_alloc0 (gslice.c:1100)
by 0x4DDF04B: g_type_create_instance (gtype.c:1913)
by 0x4DC4C1F: g_object_new_internal (gobject.c:2228)
by 0x4DC6247: g_object_new_with_properties (gobject.c:2391)
by 0x4DC6FF0: g_object_new (gobject.c:2037)
by 0x581E9EE: g_menu_item_new_section (gmenu.c:1256)
by 0x48B465F: pidgin_plugins_menu_get_item_links (pidginpluginsmenu.c:204)
by 0x5817C3F: g_menu_model_real_get_item_link (gmenumodel.c:397)
by 0x5124B78: gtk_menu_tracker_add_items (gtkmenutracker.c:313)
```

Testing Done:
Ran in `valgrind --leak-check=full` and confirmed that the leak was gone.

Reviewed at https://reviews.imfreedom.org/r/2298/
/*
* Purple - Internet Messaging Library
* Copyright (C) Pidgin Developers <devel@pidgin.im>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that `it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, see <https://www.gnu.org/licenses/>.
*/
#include "purpleconversationmember.h"
struct _PurpleConversationMember {
GObject parent;
PurpleContactInfo *contact_info;
PurpleTags *tags;
};
enum {
PROP_0,
PROP_CONTACT_INFO,
PROP_TAGS,
N_PROPERTIES
};
static GParamSpec *properties[N_PROPERTIES] = {NULL, };
G_DEFINE_TYPE(PurpleConversationMember, purple_conversation_member,
G_TYPE_OBJECT)
/******************************************************************************
* Helpers
*****************************************************************************/
static void
purple_conversation_member_set_contact_info(PurpleConversationMember *member,
PurpleContactInfo *contact_info)
{
g_return_if_fail(PURPLE_IS_CONVERSATION_MEMBER(member));
g_return_if_fail(PURPLE_IS_CONTACT_INFO(contact_info));
if(g_set_object(&member->contact_info, contact_info)) {
g_object_notify_by_pspec(G_OBJECT(member),
properties[PROP_CONTACT_INFO]);
}
}
/******************************************************************************
* GObject Implementation
*****************************************************************************/
static void
purple_conversation_member_get_property(GObject *obj, guint param_id,
GValue *value, GParamSpec *pspec)
{
PurpleConversationMember *member = PURPLE_CONVERSATION_MEMBER(obj);
switch(param_id) {
case PROP_CONTACT_INFO:
g_value_set_object(value,
purple_conversation_member_get_contact_info(member));
break;
case PROP_TAGS:
g_value_set_object(value,
purple_conversation_member_get_tags(member));
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID(obj, param_id, pspec);
break;
}
}
static void
purple_conversation_member_set_property(GObject *obj, guint param_id,
const GValue *value, GParamSpec *pspec)
{
PurpleConversationMember *member = PURPLE_CONVERSATION_MEMBER(obj);
switch(param_id) {
case PROP_CONTACT_INFO:
purple_conversation_member_set_contact_info(member,
g_value_get_object(value));
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID(obj, param_id, pspec);
break;
}
}
static void
purple_conversation_member_dispose(GObject *obj) {
PurpleConversationMember *member = PURPLE_CONVERSATION_MEMBER(obj);
g_clear_object(&member->contact_info);
G_OBJECT_CLASS(purple_conversation_member_parent_class)->dispose(obj);
}
static void
purple_conversation_member_finalize(GObject *obj) {
PurpleConversationMember *member = PURPLE_CONVERSATION_MEMBER(obj);
g_clear_object(&member->tags);
G_OBJECT_CLASS(purple_conversation_member_parent_class)->finalize(obj);
}
static void
purple_conversation_member_init(PurpleConversationMember *member) {
member->tags = purple_tags_new();
}
static void
purple_conversation_member_class_init(PurpleConversationMemberClass *klass) {
GObjectClass *obj_class = G_OBJECT_CLASS(klass);
obj_class->dispose = purple_conversation_member_dispose;
obj_class->finalize = purple_conversation_member_finalize;
obj_class->get_property = purple_conversation_member_get_property;
obj_class->set_property = purple_conversation_member_set_property;
/**
* PurpleConversationMember:contact-info:
*
* The contact info that this member is for.
*
* Since: 3.0.0
*/
properties[PROP_CONTACT_INFO] = g_param_spec_object(
"contact-info", "contact-info",
"The contact-info this member is for",
PURPLE_TYPE_CONTACT_INFO,
G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY | G_PARAM_STATIC_STRINGS);
/**
* PurpleConversationMember:tags:
*
* The [class@Purple.Tags] instance for this member.
*
* Since: 3.0.0
*/
properties[PROP_TAGS] = g_param_spec_object(
"tags", "tags",
"The tags for this member",
PURPLE_TYPE_TAGS,
G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
g_object_class_install_properties(obj_class, N_PROPERTIES, properties);
}
/******************************************************************************
* Public API
*****************************************************************************/
PurpleConversationMember *
purple_conversation_member_new(PurpleContactInfo *info) {
g_return_val_if_fail(PURPLE_IS_CONTACT_INFO(info), NULL);
return g_object_new(
PURPLE_TYPE_CONVERSATION_MEMBER,
"contact-info", info,
NULL);
}
PurpleContactInfo *
purple_conversation_member_get_contact_info(PurpleConversationMember *member) {
g_return_val_if_fail(PURPLE_IS_CONVERSATION_MEMBER(member), NULL);
return member->contact_info;
}
PurpleTags *
purple_conversation_member_get_tags(PurpleConversationMember *member) {
g_return_val_if_fail(PURPLE_IS_CONVERSATION_MEMBER(member), NULL);
return member->tags;
}