pidgin/pidgin

Split keypad into its own widget

22 months ago, Elliott Sales de Andrade
27d70d93355d
Split keypad into its own widget

Testing Done:
Temporarily added a `GtkMenuButton` with a `GtkPopover` containing this widget to the media window, so I could check the buttons. Not sure that it totally works in the final window as I didn't start a real media session.

```
diff --git a/pidgin/gtkmedia.c b/pidgin/gtkmedia.c
--- a/pidgin/gtkmedia.c
+++ b/pidgin/gtkmedia.c
@@ -261,6 +261,14 @@
}

static void
+pidgin_media_dtmf_key_pressed_debug_cb(G_GNUC_UNUSED PidginKeypad *keypad,
+ gchar num,
+ G_GNUC_UNUSED gpointer data)
+{
+ g_message("DTMF key pressed! %c", num);
+}
+
+static void
pidgin_media_init (PidginMedia *media)
{
GtkWidget *vbox;
@@ -289,6 +297,27 @@
gtk_box_pack_start(GTK_BOX(vbox), media->priv->display, TRUE, TRUE, 6);
gtk_widget_show(vbox);

+ {
+ GtkWidget *button = NULL;
+ GtkWidget *keypad = NULL;
+ GtkWidget *popover = NULL;
+
+ button = gtk_menu_button_new();
+ popover = gtk_popover_new(button);
+ gtk_menu_button_set_popover(GTK_MENU_BUTTON(button), popover);
+
+ keypad = pidgin_keypad_new();
+ pidgin_keypad_set_key_capture_widget(PIDGIN_KEYPAD(keypad),
+ GTK_WIDGET(media));
+ g_signal_connect(keypad, "pressed",
+ G_CALLBACK(pidgin_media_dtmf_key_pressed_debug_cb),
+ NULL);
+ gtk_container_add(GTK_CONTAINER(popover), keypad);
+
+ gtk_box_pack_start(GTK_BOX(vbox), button, FALSE, FALSE, 0);
+ gtk_widget_show(button);
+ }
+
g_signal_connect(G_OBJECT(media), "delete-event",
G_CALLBACK(pidgin_media_delete_event_cb), media);

```

Reviewed at https://reviews.imfreedom.org/r/1565/
/*
* purple
*
* Purple is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, see <https://www.gnu.org/licenses/>.
*/
#include "purpleprotocolmedia.h"
/******************************************************************************
* GObject Implementation
*****************************************************************************/
G_DEFINE_INTERFACE(PurpleProtocolMedia, purple_protocol_media,
PURPLE_TYPE_PROTOCOL)
static void
purple_protocol_media_default_init(PurpleProtocolMediaInterface *iface) {
}
/******************************************************************************
* Public API
*****************************************************************************/
gboolean
purple_protocol_media_initiate_session(PurpleProtocolMedia *media,
PurpleAccount *account,
const gchar *who,
PurpleMediaSessionType type)
{
PurpleProtocolMediaInterface *iface = NULL;
g_return_val_if_fail(PURPLE_IS_PROTOCOL_MEDIA(media), FALSE);
iface = PURPLE_PROTOCOL_MEDIA_GET_IFACE(media);
if(iface && iface->initiate_session) {
return iface->initiate_session(media, account, who, type);
}
return FALSE;
}
PurpleMediaCaps
purple_protocol_media_get_caps(PurpleProtocolMedia *media,
PurpleAccount *account, const gchar *who)
{
PurpleProtocolMediaInterface *iface = NULL;
g_return_val_if_fail(PURPLE_IS_PROTOCOL_MEDIA(media), PURPLE_MEDIA_NONE);
iface = PURPLE_PROTOCOL_MEDIA_GET_IFACE(media);
if(iface && iface->get_caps) {
return iface->get_caps(media, account, who);
}
return PURPLE_MEDIA_NONE;
}
gboolean
purple_protocol_media_send_dtmf(PurpleProtocolMedia *protocol_media,
PurpleMedia *media, gchar dtmf, guint8 volume,
guint8 duration)
{
PurpleProtocolMediaInterface *iface = NULL;
g_return_val_if_fail(PURPLE_IS_PROTOCOL_MEDIA(protocol_media), FALSE);
iface = PURPLE_PROTOCOL_MEDIA_GET_IFACE(protocol_media);
if(iface && iface->send_dtmf) {
return iface->send_dtmf(protocol_media, media, dtmf, volume, duration);
}
return FALSE;
}