pidgin/pidgin

Split keypad into its own widget

22 months ago, Elliott Sales de Andrade
27d70d93355d
Split keypad into its own widget

Testing Done:
Temporarily added a `GtkMenuButton` with a `GtkPopover` containing this widget to the media window, so I could check the buttons. Not sure that it totally works in the final window as I didn't start a real media session.

```
diff --git a/pidgin/gtkmedia.c b/pidgin/gtkmedia.c
--- a/pidgin/gtkmedia.c
+++ b/pidgin/gtkmedia.c
@@ -261,6 +261,14 @@
}

static void
+pidgin_media_dtmf_key_pressed_debug_cb(G_GNUC_UNUSED PidginKeypad *keypad,
+ gchar num,
+ G_GNUC_UNUSED gpointer data)
+{
+ g_message("DTMF key pressed! %c", num);
+}
+
+static void
pidgin_media_init (PidginMedia *media)
{
GtkWidget *vbox;
@@ -289,6 +297,27 @@
gtk_box_pack_start(GTK_BOX(vbox), media->priv->display, TRUE, TRUE, 6);
gtk_widget_show(vbox);

+ {
+ GtkWidget *button = NULL;
+ GtkWidget *keypad = NULL;
+ GtkWidget *popover = NULL;
+
+ button = gtk_menu_button_new();
+ popover = gtk_popover_new(button);
+ gtk_menu_button_set_popover(GTK_MENU_BUTTON(button), popover);
+
+ keypad = pidgin_keypad_new();
+ pidgin_keypad_set_key_capture_widget(PIDGIN_KEYPAD(keypad),
+ GTK_WIDGET(media));
+ g_signal_connect(keypad, "pressed",
+ G_CALLBACK(pidgin_media_dtmf_key_pressed_debug_cb),
+ NULL);
+ gtk_container_add(GTK_CONTAINER(popover), keypad);
+
+ gtk_box_pack_start(GTK_BOX(vbox), button, FALSE, FALSE, 0);
+ gtk_widget_show(button);
+ }
+
g_signal_connect(G_OBJECT(media), "delete-event",
G_CALLBACK(pidgin_media_delete_event_cb), media);

```

Reviewed at https://reviews.imfreedom.org/r/1565/
/*
* Purple - Internet Messaging Library
* Copyright (C) Pidgin Developers <devel@pidgin.im>
*
* Purple is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, see <https://www.gnu.org/licenses/>.
*/
#if !defined(PURPLE_GLOBAL_HEADER_INSIDE) && !defined(PURPLE_COMPILATION)
# error "only <purple.h> may be included directly"
#endif
#ifndef PURPLE_PROTOCOL_FACTORY_H
#define PURPLE_PROTOCOL_FACTORY_H
#include <glib.h>
#include <glib-object.h>
#include <libpurple/account.h>
#include <libpurple/connection.h>
#include <libpurple/purpleprotocol.h>
#include <libpurple/roomlist.h>
G_BEGIN_DECLS
/**
* PURPLE_TYPE_PROTOCOL_FACTORY:
*
* The standard _get_type macro for #PurpleProtocolFactory.
*/
#define PURPLE_TYPE_PROTOCOL_FACTORY (purple_protocol_factory_iface_get_type())
/**
* PurpleProtocolFactory:
*
* An interface where protocols can expose subclasses of libpurple objects.
*
* Since: 3.0.0
*/
G_DECLARE_INTERFACE(PurpleProtocolFactory, purple_protocol_factory, PURPLE,
PROTOCOL_FACTORY, PurpleProtocol)
/**
* PurpleProtocolFactoryInterface:
* @connection_new: Creates a new protocol-specific connection object that
* subclasses #PurpleConnection.
* @roomlist_new: Creates a new protocol-specific room list object that
* subclasses #PurpleRoomlist.
* @whiteboard_new: Creates a new protocol-specific whiteboard object that
* subclasses #PurpleWhiteboard.
*
* The protocol factory interface.
*
* This interface provides callbacks for construction of protocol-specific
* subclasses of some purple objects.
*/
struct _PurpleProtocolFactoryInterface {
/*< private >*/
GTypeInterface parent_iface;
/*< public >*/
PurpleConnection *(*connection_new)(PurpleProtocolFactory *factory,
PurpleAccount *account,
const gchar *password);
PurpleWhiteboard *(*whiteboard_new)(PurpleProtocolFactory *factory,
PurpleAccount *account,
const gchar *who,
gint state);
};
/**
* purple_protocol_factory_get_type:
*
* The standard `_get_type` function for #PurpleProtocolFactory.
*
* Returns: The #GType for the protocol factory interface.
*
* Since: 3.0.0
*/
/**
* purple_protocol_factory_connection_new:
* @factory: The #PurpleProtocolFactory instance.
* @account: The #PurpleAccount to create the connection for.
* @password: The password for @account.
*
* Creates a new protocol-specific #PurpleConnection subclass.
*
* Returns: (transfer full): The new #PurpleConnection subclass.
*
* Since: 3.0.0
*/
PurpleConnection *purple_protocol_factory_connection_new(PurpleProtocolFactory *factory,
PurpleAccount *account, const gchar *password);
/**
* purple_protocol_factory_whiteboard_new:
* @factory: The #PurpleProtocolFactory instance.
* @account: The #PurpleAccount instance to create a whiteboard for.
* @who: The name of the contact to create a whiteboard with.
* @state: NFI.
*
* Creates a new protocol-specific #PurpleWhiteboard subclass.
*
* Returns: (transfer full): The new #PurpleWhiteboard subclass for @account
* and @who.
*
* Since: 3.0.0
*/
PurpleWhiteboard *purple_protocol_factory_whiteboard_new(PurpleProtocolFactory *factory,
PurpleAccount *account, const gchar *who, gint state);
G_END_DECLS
#endif /* PURPLE_PROTOCOL_FACTORY_H */