pidgin/pidgin

Split keypad into its own widget

22 months ago, Elliott Sales de Andrade
27d70d93355d
Split keypad into its own widget

Testing Done:
Temporarily added a `GtkMenuButton` with a `GtkPopover` containing this widget to the media window, so I could check the buttons. Not sure that it totally works in the final window as I didn't start a real media session.

```
diff --git a/pidgin/gtkmedia.c b/pidgin/gtkmedia.c
--- a/pidgin/gtkmedia.c
+++ b/pidgin/gtkmedia.c
@@ -261,6 +261,14 @@
}

static void
+pidgin_media_dtmf_key_pressed_debug_cb(G_GNUC_UNUSED PidginKeypad *keypad,
+ gchar num,
+ G_GNUC_UNUSED gpointer data)
+{
+ g_message("DTMF key pressed! %c", num);
+}
+
+static void
pidgin_media_init (PidginMedia *media)
{
GtkWidget *vbox;
@@ -289,6 +297,27 @@
gtk_box_pack_start(GTK_BOX(vbox), media->priv->display, TRUE, TRUE, 6);
gtk_widget_show(vbox);

+ {
+ GtkWidget *button = NULL;
+ GtkWidget *keypad = NULL;
+ GtkWidget *popover = NULL;
+
+ button = gtk_menu_button_new();
+ popover = gtk_popover_new(button);
+ gtk_menu_button_set_popover(GTK_MENU_BUTTON(button), popover);
+
+ keypad = pidgin_keypad_new();
+ pidgin_keypad_set_key_capture_widget(PIDGIN_KEYPAD(keypad),
+ GTK_WIDGET(media));
+ g_signal_connect(keypad, "pressed",
+ G_CALLBACK(pidgin_media_dtmf_key_pressed_debug_cb),
+ NULL);
+ gtk_container_add(GTK_CONTAINER(popover), keypad);
+
+ gtk_box_pack_start(GTK_BOX(vbox), button, FALSE, FALSE, 0);
+ gtk_widget_show(button);
+ }
+
g_signal_connect(G_OBJECT(media), "delete-event",
G_CALLBACK(pidgin_media_delete_event_cb), media);

```

Reviewed at https://reviews.imfreedom.org/r/1565/
/*
* Purple - Internet Messaging Library
* Copyright (C) Pidgin Developers <devel@pidgin.im>
*
* Purple is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, see <https://www.gnu.org/licenses/>.
*/
#include "purpleprotocolclient.h"
/******************************************************************************
* GObject Implementation
*****************************************************************************/
G_DEFINE_INTERFACE(PurpleProtocolClient, purple_protocol_client,
PURPLE_TYPE_PROTOCOL)
static void
purple_protocol_client_default_init(PurpleProtocolClientInterface *iface) {
}
/******************************************************************************
* Public API
*****************************************************************************/
GList *
purple_protocol_client_get_actions(PurpleProtocolClient *client,
PurpleConnection *connection)
{
PurpleProtocolClientInterface *iface = NULL;
g_return_val_if_fail(PURPLE_IS_PROTOCOL_CLIENT(client), NULL);
g_return_val_if_fail(PURPLE_IS_CONNECTION(connection), NULL);
iface = PURPLE_PROTOCOL_CLIENT_GET_IFACE(client);
if(iface != NULL && iface->get_actions != NULL) {
return iface->get_actions(client, connection);
}
return NULL;
}
const gchar *
purple_protocol_client_list_emblem(PurpleProtocolClient *client,
PurpleBuddy *buddy)
{
PurpleProtocolClientInterface *iface = NULL;
g_return_val_if_fail(PURPLE_IS_PROTOCOL_CLIENT(client), NULL);
g_return_val_if_fail(PURPLE_IS_BUDDY(buddy), NULL);
iface = PURPLE_PROTOCOL_CLIENT_GET_IFACE(client);
if(iface != NULL && iface->list_emblem != NULL) {
return iface->list_emblem(client, buddy);
}
return NULL;
}
gchar *
purple_protocol_client_status_text(PurpleProtocolClient *client,
PurpleBuddy *buddy)
{
PurpleProtocolClientInterface *iface = NULL;
g_return_val_if_fail(PURPLE_IS_PROTOCOL_CLIENT(client), NULL);
g_return_val_if_fail(PURPLE_IS_BUDDY(buddy), NULL);
iface = PURPLE_PROTOCOL_CLIENT_GET_IFACE(client);
if(iface != NULL && iface->status_text != NULL) {
return iface->status_text(client, buddy);
}
return NULL;
}
void
purple_protocol_client_tooltip_text(PurpleProtocolClient *client,
PurpleBuddy *buddy,
PurpleNotifyUserInfo *user_info,
gboolean full)
{
PurpleProtocolClientInterface *iface = NULL;
g_return_if_fail(PURPLE_IS_PROTOCOL_CLIENT(client));
g_return_if_fail(PURPLE_IS_BUDDY(buddy));
g_return_if_fail(user_info != NULL);
iface = PURPLE_PROTOCOL_CLIENT_GET_IFACE(client);
if(iface != NULL && iface->tooltip_text != NULL) {
iface->tooltip_text(client, buddy, user_info, full);
}
}
GList *
purple_protocol_client_blist_node_menu(PurpleProtocolClient *client,
PurpleBlistNode *node)
{
PurpleProtocolClientInterface *iface = NULL;
g_return_val_if_fail(PURPLE_IS_PROTOCOL_CLIENT(client), NULL);
g_return_val_if_fail(PURPLE_IS_BLIST_NODE(node), NULL);
iface = PURPLE_PROTOCOL_CLIENT_GET_IFACE(client);
if(iface != NULL && iface->blist_node_menu != NULL) {
return iface->blist_node_menu(client, node);
}
return NULL;
}
void
purple_protocol_client_buddy_free(PurpleProtocolClient *client,
PurpleBuddy *buddy)
{
PurpleProtocolClientInterface *iface = NULL;
g_return_if_fail(PURPLE_IS_PROTOCOL_CLIENT(client));
g_return_if_fail(PURPLE_IS_BUDDY(buddy));
iface = PURPLE_PROTOCOL_CLIENT_GET_IFACE(client);
if(iface != NULL && iface->buddy_free != NULL) {
iface->buddy_free(client, buddy);
}
}
void
purple_protocol_client_convo_closed(PurpleProtocolClient *client,
PurpleConnection *connection,
const gchar *who)
{
PurpleProtocolClientInterface *iface = NULL;
g_return_if_fail(PURPLE_IS_PROTOCOL_CLIENT(client));
g_return_if_fail(PURPLE_IS_CONNECTION(connection));
g_return_if_fail(who != NULL);
iface = PURPLE_PROTOCOL_CLIENT_GET_IFACE(client);
if(iface != NULL && iface->convo_closed != NULL) {
iface->convo_closed(client, connection, who);
}
}
const gchar *
purple_protocol_client_normalize(PurpleProtocolClient *client,
PurpleAccount *account, const gchar *who)
{
PurpleProtocolClientInterface *iface = NULL;
g_return_val_if_fail(PURPLE_IS_PROTOCOL_CLIENT(client), NULL);
g_return_val_if_fail(who != NULL, NULL);
iface = PURPLE_PROTOCOL_CLIENT_GET_IFACE(client);
if(iface != NULL && iface->normalize != NULL) {
return iface->normalize(client, account, who);
}
return NULL;
}
PurpleChat *
purple_protocol_client_find_blist_chat(PurpleProtocolClient *client,
PurpleAccount *account,
const gchar *name)
{
PurpleProtocolClientInterface *iface = NULL;
g_return_val_if_fail(PURPLE_IS_PROTOCOL_CLIENT(client), NULL);
g_return_val_if_fail(PURPLE_IS_ACCOUNT(account), NULL);
g_return_val_if_fail(name != NULL, NULL);
iface = PURPLE_PROTOCOL_CLIENT_GET_IFACE(client);
if(iface != NULL && iface->find_blist_chat != NULL) {
return iface->find_blist_chat(client, account, name);
}
return NULL;
}
gboolean
purple_protocol_client_offline_message(PurpleProtocolClient *client,
PurpleBuddy *buddy)
{
PurpleProtocolClientInterface *iface = NULL;
g_return_val_if_fail(PURPLE_IS_PROTOCOL_CLIENT(client), FALSE);
g_return_val_if_fail(PURPLE_IS_BUDDY(buddy), FALSE);
iface = PURPLE_PROTOCOL_CLIENT_GET_IFACE(client);
if(iface != NULL && iface->offline_message != NULL) {
return iface->offline_message(client, buddy);
}
return FALSE;
}
GHashTable *
purple_protocol_client_get_account_text_table(PurpleProtocolClient *client,
PurpleAccount *account)
{
PurpleProtocolClientInterface *iface = NULL;
g_return_val_if_fail(PURPLE_IS_PROTOCOL_CLIENT(client), NULL);
g_return_val_if_fail(PURPLE_IS_ACCOUNT(account), NULL);
iface = PURPLE_PROTOCOL_CLIENT_GET_IFACE(client);
if(iface != NULL && iface->get_account_text_table != NULL) {
return iface->get_account_text_table(client, account);
}
return NULL;
}
PurpleMood *
purple_protocol_client_get_moods(PurpleProtocolClient *client,
PurpleAccount *account)
{
PurpleProtocolClientInterface *iface = NULL;
g_return_val_if_fail(PURPLE_IS_PROTOCOL_CLIENT(client), NULL);
g_return_val_if_fail(PURPLE_IS_ACCOUNT(account), NULL);
iface = PURPLE_PROTOCOL_CLIENT_GET_IFACE(client);
if(iface != NULL && iface->get_moods != NULL) {
return iface->get_moods(client, account);
}
return NULL;
}
gssize
purple_protocol_client_get_max_message_size(PurpleProtocolClient *client,
PurpleConversation *conv)
{
PurpleProtocolClientInterface *iface = NULL;
g_return_val_if_fail(PURPLE_IS_PROTOCOL_CLIENT(client), 0);
g_return_val_if_fail(PURPLE_IS_CONVERSATION(conv), 0);
iface = PURPLE_PROTOCOL_CLIENT_GET_IFACE(client);
if(iface != NULL && iface->get_max_message_size != NULL) {
return iface->get_max_message_size(client, conv);
}
return 0;
}