pidgin/pidgin

Split keypad into its own widget

22 months ago, Elliott Sales de Andrade
27d70d93355d
Split keypad into its own widget

Testing Done:
Temporarily added a `GtkMenuButton` with a `GtkPopover` containing this widget to the media window, so I could check the buttons. Not sure that it totally works in the final window as I didn't start a real media session.

```
diff --git a/pidgin/gtkmedia.c b/pidgin/gtkmedia.c
--- a/pidgin/gtkmedia.c
+++ b/pidgin/gtkmedia.c
@@ -261,6 +261,14 @@
}

static void
+pidgin_media_dtmf_key_pressed_debug_cb(G_GNUC_UNUSED PidginKeypad *keypad,
+ gchar num,
+ G_GNUC_UNUSED gpointer data)
+{
+ g_message("DTMF key pressed! %c", num);
+}
+
+static void
pidgin_media_init (PidginMedia *media)
{
GtkWidget *vbox;
@@ -289,6 +297,27 @@
gtk_box_pack_start(GTK_BOX(vbox), media->priv->display, TRUE, TRUE, 6);
gtk_widget_show(vbox);

+ {
+ GtkWidget *button = NULL;
+ GtkWidget *keypad = NULL;
+ GtkWidget *popover = NULL;
+
+ button = gtk_menu_button_new();
+ popover = gtk_popover_new(button);
+ gtk_menu_button_set_popover(GTK_MENU_BUTTON(button), popover);
+
+ keypad = pidgin_keypad_new();
+ pidgin_keypad_set_key_capture_widget(PIDGIN_KEYPAD(keypad),
+ GTK_WIDGET(media));
+ g_signal_connect(keypad, "pressed",
+ G_CALLBACK(pidgin_media_dtmf_key_pressed_debug_cb),
+ NULL);
+ gtk_container_add(GTK_CONTAINER(popover), keypad);
+
+ gtk_box_pack_start(GTK_BOX(vbox), button, FALSE, FALSE, 0);
+ gtk_widget_show(button);
+ }
+
g_signal_connect(G_OBJECT(media), "delete-event",
G_CALLBACK(pidgin_media_delete_event_cb), media);

```

Reviewed at https://reviews.imfreedom.org/r/1565/
/* purple
*
* Purple is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA
*/
#if !defined(PURPLE_GLOBAL_HEADER_INSIDE) && !defined(PURPLE_COMPILATION)
# error "only <purple.h> may be included directly"
#endif
#ifndef PURPLE_ACCOUNTS_H
#define PURPLE_ACCOUNTS_H
#include "account.h"
#include "status.h"
#define PURPLE_TYPE_ACCOUNT_UI_OPS (purple_account_ui_ops_get_type())
typedef struct _PurpleAccountUiOps PurpleAccountUiOps;
/**
* PurpleAccountUiOps:
* @status_changed: This account's status changed.
* @request_add: Someone we don't have on our list added us; prompt
* to add them.
* @request_authorize: Prompt for authorization when someone adds this
* account to their buddy list. To authorize them to
* see this account's presence, call
* @authorize_cb (@message, @user_data) otherwise call
* @deny_cb (@message, @user_data).
* <sbr/>Returns: A UI-specific handle, as passed to
* @close_account_request.
* @close_account_request: Close a pending request for authorization.
* @ui_handle is a handle as returned by
* @request_authorize.
* @permit_added: Called during a call to purple_account_privacy_permit_add().
* @permit_removed: Called during a call to
* purple_account_privacy_permit_removed().
* @deny_added: Called during a call to purple_account_privacy_deny_add().
* @deny_removed: Called during a call to
* purple_account_privacy_deny_removed().
*
* Account UI operations, used to notify the user of status changes and when
* buddies add this account to their buddy lists.
*/
struct _PurpleAccountUiOps
{
void (*status_changed)(PurpleAccount *account,
PurpleStatus *status);
void (*request_add)(PurpleAccount *account,
const char *remote_user,
const char *id,
const char *alias,
const char *message);
void *(*request_authorize)(PurpleAccount *account,
const char *remote_user,
const char *id,
const char *alias,
const char *message,
gboolean on_list,
PurpleAccountRequestAuthorizationCb authorize_cb,
PurpleAccountRequestAuthorizationCb deny_cb,
void *user_data);
void (*close_account_request)(void *ui_handle);
void (*permit_added)(PurpleAccount *account, const char *name);
void (*permit_removed)(PurpleAccount *account, const char *name);
void (*deny_added)(PurpleAccount *account, const char *name);
void (*deny_removed)(PurpleAccount *account, const char *name);
/*< private >*/
gpointer reserved[4];
};
G_BEGIN_DECLS
/**************************************************************************/
/* Accounts API */
/**************************************************************************/
/**
* purple_accounts_delete:
* @account: The account.
*
* Deletes an account.
*
* This will remove any buddies from the buddy list that belong to this
* account, buddy pounces that belong to this account, and will also
* destroy @account.
*/
void purple_accounts_delete(PurpleAccount *account);
/**
* purple_accounts_restore_current_statuses:
*
* This is called by the core after all subsystems and what
* not have been initialized. It sets all enabled accounts
* to their startup status by signing them on, setting them
* away, etc.
*
* You probably shouldn't call this unless you really know
* what you're doing.
*/
void purple_accounts_restore_current_statuses(void);
/**************************************************************************/
/* UI Registration Functions */
/**************************************************************************/
/**
* purple_account_ui_ops_get_type:
*
* Returns: The #GType for the #PurpleAccountUiOps boxed structure.
*/
GType purple_account_ui_ops_get_type(void);
/**
* purple_accounts_set_ui_ops:
* @ops: The UI operations structure.
*
* Sets the UI operations structure to be used for accounts.
*/
void purple_accounts_set_ui_ops(PurpleAccountUiOps *ops);
/**
* purple_accounts_get_ui_ops:
*
* Returns the UI operations structure used for accounts.
*
* Returns: The UI operations structure in use.
*/
PurpleAccountUiOps *purple_accounts_get_ui_ops(void);
/**************************************************************************/
/* Accounts Subsystem */
/**************************************************************************/
/**
* purple_accounts_get_handle:
*
* Returns the accounts subsystem handle.
*
* Returns: The accounts subsystem handle.
*/
void *purple_accounts_get_handle(void);
/**
* purple_accounts_init:
*
* Initializes the accounts subsystem.
*/
void purple_accounts_init(void);
/**
* purple_accounts_uninit:
*
* Uninitializes the accounts subsystem.
*/
void purple_accounts_uninit(void);
/**
* purple_accounts_schedule_save:
*
* Schedules saving of accounts
*/
void purple_accounts_schedule_save(void);
G_END_DECLS
#endif /* PURPLE_ACCOUNTS_H */