pidgin/pidgin

Re-arrange jabber_buddy_resource_free to avoid use-after-free warning.

2019-11-05, Elliott Sales de Andrade
27c5004a6c65
Re-arrange jabber_buddy_resource_free to avoid use-after-free warning.

scan-build doesn't recognize the effect of g_list_remove, but this seems
a bit cleaner anyway.
/* This file is part of the Project Athena Zephyr Notification System.
* It contains source for the ZSendNotice function.
*
* Created by: Robert French
*
* Copyright (c) 1987 by the Massachusetts Institute of Technology.
* For copying and distribution information, see the file
* "mit-copyright.h".
*/
#include "internal.h"
Code_t ZSendNotice(notice, cert_routine)
ZNotice_t *notice;
Z_AuthProc cert_routine;
{
return(ZSrvSendNotice(notice, cert_routine, Z_XmitFragment));
}
Code_t ZSrvSendNotice(notice, cert_routine, send_routine)
ZNotice_t *notice;
Z_AuthProc cert_routine;
Code_t (*send_routine)();
{
Code_t retval;
ZNotice_t newnotice;
char *buffer;
int len;
if ((retval = ZFormatNotice(notice, &buffer, &len,
cert_routine)) != ZERR_NONE)
return (retval);
if ((retval = ZParseNotice(buffer, len, &newnotice)) != ZERR_NONE)
return (retval);
retval = Z_SendFragmentedNotice(&newnotice, len, cert_routine,
send_routine);
free(buffer);
return (retval);
}