pidgin/pidgin

Fix new request warning in New IM dialog

15 months ago, Elliott Sales de Andrade
1a481edc6307
Fix new request warning in New IM dialog

Setting the validator triggers the field's `valid` property notification, which triggers the group to refresh its validity, which fetches the `valid` property and runs the validator.

But the validator depends on the account field which hasn't been created yet, which causes a type-check warning.

So set the validator after all fields are made, and also change the data argument so the dependency is clearer.

Testing Done:
Compiled, and opened the New IM dialog.

Reviewed at https://reviews.imfreedom.org/r/2358/
/**
* Copyright (C) 2009 Richard Nelson <wabz@whatsbeef.net>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA
*/
#include <glib/gi18n-lib.h>
#include <glib.h>
#include <libsoup/soup.h>
#define PREFS_SCHEMA "im.pidgin.Finch.plugin.TinyURL"
#define PREF_LENGTH "length"
#define PREF_URL "url"
#include <purple.h>
#include <gnt.h>
#include <finch.h>
static int tag_num = 0;
static SoupSession *session = NULL;
static GHashTable *tinyurl_cache = NULL;
typedef struct {
SoupMessage *msg;
gchar *original_url;
PurpleConversation *conv;
gchar *tag;
int num;
} CbInfo;
static void process_urls(PurpleConversation *conv, GList *urls);
/* 3 functions from util.c */
static gboolean
badchar(char c)
{
switch (c) {
case ' ':
case ',':
case '\0':
case '\n':
case '\r':
case '<':
case '>':
case '"':
case '\'':
return TRUE;
default:
return FALSE;
}
}
static gboolean
badentity(const char *c)
{
if (!g_ascii_strncasecmp(c, "&lt;", 4) ||
!g_ascii_strncasecmp(c, "&gt;", 4) ||
!g_ascii_strncasecmp(c, "&quot;", 6)) {
return TRUE;
}
return FALSE;
}
static GList *extract_urls(const char *text)
{
const char *t, *c, *q = NULL;
char *url_buf;
GList *ret = NULL;
gboolean inside_html = FALSE;
int inside_paren = 0;
c = text;
while (*c) {
if (*c == '(' && !inside_html) {
inside_paren++;
c++;
}
if (inside_html) {
if (*c == '>') {
inside_html = FALSE;
} else if (!q && (*c == '\"' || *c == '\'')) {
q = c;
} else if(q) {
if(*c == *q)
q = NULL;
}
} else if (*c == '<') {
inside_html = TRUE;
if (!g_ascii_strncasecmp(c, "<A", 2)) {
while (1) {
if (*c == '>') {
inside_html = FALSE;
break;
}
c++;
if (!(*c))
break;
}
}
} else if ((*c=='h') && (!g_ascii_strncasecmp(c, "http://", 7) ||
(!g_ascii_strncasecmp(c, "https://", 8)))) {
t = c;
while (1) {
if (badchar(*t) || badentity(t)) {
if ((!g_ascii_strncasecmp(c, "http://", 7) && (t - c == 7)) ||
(!g_ascii_strncasecmp(c, "https://", 8) && (t - c == 8))) {
break;
}
if (*(t) == ',' && (*(t + 1) != ' ')) {
t++;
continue;
}
if (*(t - 1) == '.')
t--;
if ((*(t - 1) == ')' && (inside_paren > 0))) {
t--;
}
url_buf = g_strndup(c, t - c);
if (!g_list_find_custom(ret, url_buf, (GCompareFunc)strcmp)) {
purple_debug_info("TinyURL", "Added URL %s\n", url_buf);
ret = g_list_append(ret, url_buf);
} else {
g_free(url_buf);
}
c = t;
break;
}
t++;
}
} else if (!g_ascii_strncasecmp(c, "www.", 4) && (c == text || badchar(c[-1]) || badentity(c-1))) {
if (c[4] != '.') {
t = c;
while (1) {
if (badchar(*t) || badentity(t)) {
if (t - c == 4) {
break;
}
if (*(t) == ',' && (*(t + 1) != ' ')) {
t++;
continue;
}
if (*(t - 1) == '.')
t--;
if ((*(t - 1) == ')' && (inside_paren > 0))) {
t--;
}
url_buf = g_strndup(c, t - c);
if (!g_list_find_custom(ret, url_buf, (GCompareFunc)strcmp)) {
purple_debug_info("TinyURL", "Added URL %s\n", url_buf);
ret = g_list_append(ret, url_buf);
} else {
g_free(url_buf);
}
c = t;
break;
}
t++;
}
}
}
if (*c == ')' && !inside_html) {
inside_paren--;
c++;
}
if (*c == 0)
break;
c++;
}
return ret;
}
static void
url_fetched(GObject *source, GAsyncResult *result, gpointer user_data) {
CbInfo *data = (CbInfo *)user_data;
PurpleConversation *conv = data->conv;
PurpleConversationManager *manager;
GList *convs;
GBytes *response_body = NULL;
const gchar *url;
manager = purple_conversation_manager_get_default();
convs = purple_conversation_manager_get_all(manager);
if(SOUP_STATUS_IS_SUCCESSFUL(soup_message_get_status(data->msg))) {
response_body = soup_session_send_and_read_finish(SOUP_SESSION(source),
result, NULL);
}
if (response_body != NULL) {
gchar *tmp = NULL;
gsize size = 0;
/* Ensure URL is NUL-terminated. */
url = g_bytes_get_data(response_body, &size);
tmp = g_strndup(url, size);
url = tmp;
g_hash_table_insert(tinyurl_cache, data->original_url, tmp);
g_bytes_unref(response_body);
} else {
url = _("Error while querying TinyURL");
g_free(data->original_url);
}
/* ensure the conversation still exists */
if (g_list_find(convs, conv)) {
FinchConv *fconv = FINCH_CONV(conv);
gchar *str = g_strdup_printf("[%d] %s", data->num, url);
GntTextView *tv = GNT_TEXT_VIEW(fconv->tv);
gnt_text_view_tag_change(tv, data->tag, str, FALSE);
g_free(str);
g_free(data->tag);
g_object_unref(data->msg);
g_free(data);
return;
}
g_free(data->tag);
g_object_unref(data->msg);
g_free(data);
purple_debug_info("TinyURL", "Conversation no longer exists... :(\n");
}
static gboolean
writing_msg(PurpleConversation *conv, PurpleMessage *msg,
G_GNUC_UNUSED gpointer data)
{
GString *t;
GList *iter, *urls, *next;
int c = 0;
GSettings *settings = NULL;
gint min_url_length;
if (purple_message_get_flags(msg) & (PURPLE_MESSAGE_SEND | PURPLE_MESSAGE_INVISIBLE))
return FALSE;
urls = g_object_get_data(G_OBJECT(conv), "TinyURLs");
g_list_free_full(urls, g_free);
urls = extract_urls(purple_message_get_contents(msg));
if (!urls)
return FALSE;
settings = g_settings_new_with_backend(PREFS_SCHEMA,
purple_core_get_settings_backend());
min_url_length = g_settings_get_int(settings, PREF_LENGTH);
g_object_unref(settings);
t = g_string_new(g_strdup(purple_message_get_contents(msg)));
for (iter = urls; iter; iter = next) {
next = iter->next;
if (g_utf8_strlen((char *)iter->data, -1) >= min_url_length) {
int pos, x = 0;
gchar *j, *s, *str, *orig;
glong len = g_utf8_strlen(iter->data, -1);
s = g_strdup(t->str);
orig = s;
str = g_strdup_printf("[%d]", ++c);
while ((j = strstr(s, iter->data))) { /* replace all occurrences */
pos = j - orig + (x++ * 3);
s = j + len;
t = g_string_insert(t, pos + len, str);
if (*s == '\0') break;
}
g_free(orig);
g_free(str);
continue;
} else {
g_free(iter->data);
urls = g_list_delete_link(urls, iter);
}
}
purple_message_set_contents(msg, t->str);
g_string_free(t, TRUE);
if (conv != NULL)
g_object_set_data(G_OBJECT(conv), "TinyURLs", urls);
return FALSE;
}
static void
wrote_msg(PurpleConversation *conv, PurpleMessage *pmsg,
G_GNUC_UNUSED gpointer _unused)
{
GList *urls;
if (purple_message_get_flags(pmsg) & PURPLE_MESSAGE_SEND)
return;
urls = g_object_get_data(G_OBJECT(conv), "TinyURLs");
if (urls == NULL)
return;
process_urls(conv, urls);
g_object_set_data(G_OBJECT(conv), "TinyURLs", NULL);
}
/* Frees 'urls' */
static void
process_urls(PurpleConversation *conv, GList *urls)
{
GList *iter;
int c;
FinchConv *fconv = FINCH_CONV(conv);
GntTextView *tv = GNT_TEXT_VIEW(fconv->tv);
GSettings *settings = NULL;
gchar *tinyurl_prefix = NULL;
settings = g_settings_new_with_backend(PREFS_SCHEMA,
purple_core_get_settings_backend());
tinyurl_prefix = g_settings_get_string(settings, PREF_URL);
g_object_unref(settings);
for (iter = urls, c = 1; iter; iter = iter->next, c++) {
int i;
SoupMessage *msg;
CbInfo *cbdata;
gchar *url;
gchar *original_url;
const gchar *tiny_url;
i = gnt_text_view_get_lines_below(tv);
original_url = purple_unescape_html((char *)iter->data);
tiny_url = g_hash_table_lookup(tinyurl_cache, original_url);
if (tiny_url) {
gchar *str = g_strdup_printf("\n[%d] %s", c, tiny_url);
g_free(original_url);
gnt_text_view_append_text_with_flags(tv, str, GNT_TEXT_FLAG_DIM);
if (i == 0)
gnt_text_view_scroll(tv, 0);
g_free(str);
continue;
}
cbdata = g_new(CbInfo, 1);
cbdata->num = c;
cbdata->original_url = original_url;
cbdata->tag = g_strdup_printf("%s%d", "tiny_", tag_num++);
cbdata->conv = conv;
if (g_ascii_strncasecmp(original_url, "http://", 7) && g_ascii_strncasecmp(original_url, "https://", 8)) {
url = g_strdup_printf("%shttp%%3A%%2F%%2F%s", tinyurl_prefix,
purple_url_encode(original_url));
} else {
url = g_strdup_printf("%s%s", tinyurl_prefix,
purple_url_encode(original_url));
}
cbdata->msg = msg = soup_message_new("GET", url);
soup_session_send_and_read_async(session, msg, G_PRIORITY_DEFAULT,
NULL, url_fetched, cbdata);
gnt_text_view_append_text_with_tag((tv), _("\nFetching TinyURL..."),
GNT_TEXT_FLAG_DIM, cbdata->tag);
if (i == 0)
gnt_text_view_scroll(tv, 0);
g_free(iter->data);
g_free(url);
}
g_list_free(urls);
g_free(tinyurl_prefix);
}
static void
free_conv_urls(PurpleConversation *conv)
{
GList *urls = g_object_get_data(G_OBJECT(conv), "TinyURLs");
g_list_free_full(urls, g_free);
}
static void
tinyurl_notify_tinyuri(GntWidget *win, const gchar *url)
{
gchar *message;
GntWidget *label = g_object_get_data(G_OBJECT(win), "info-widget");
message = g_strdup_printf(_("TinyURL for above: %s"), url);
gnt_label_set_text(GNT_LABEL(label), message);
g_free(message);
}
static void
tinyurl_notify_fetch_cb(GObject *source, GAsyncResult *result, gpointer data)
{
SoupMessage *msg = data;
GntWidget *win = NULL;
GBytes *response_body = NULL;
const gchar *tmp = NULL;
gsize size = 0;
gchar *url = NULL;
const gchar *original_url = NULL;
if(SOUP_STATUS_IS_SUCCESSFUL(soup_message_get_status(msg))) {
response_body = soup_session_send_and_read_finish(SOUP_SESSION(source),
result, NULL);
}
if (response_body == NULL) {
g_object_unref(msg);
return;
}
win = g_object_get_data(G_OBJECT(msg), "gnttinyurl-window");
original_url = g_object_get_data(G_OBJECT(msg), "gnttinyurl-original");
tmp = g_bytes_get_data(response_body, &size);
url = g_strndup(tmp, size);
g_hash_table_insert(tinyurl_cache, g_strdup(original_url), url);
tinyurl_notify_tinyuri(win, url);
g_bytes_unref(response_body);
g_object_unref(msg);
}
static void *
tinyurl_notify_uri(const char *uri)
{
char *fullurl = NULL;
GntWidget *win;
GCancellable *cancellable = NULL;
SoupMessage *msg;
const gchar *tiny_url;
GSettings *settings = NULL;
gchar *tinyurl_prefix = NULL;
/* XXX: The following expects that finch_notify_message gets called. This
* may not always happen, e.g. when another plugin sets its own
* notify_message. So tread carefully. */
win = purple_notify_message(NULL, PURPLE_NOTIFY_MSG_INFO, _("URI"), uri,
_("Please wait while TinyURL fetches a shorter URL ..."), NULL, NULL, NULL);
if (!GNT_IS_WINDOW(win) || !g_object_get_data(G_OBJECT(win), "info-widget"))
return win;
tiny_url = g_hash_table_lookup(tinyurl_cache, uri);
if (tiny_url) {
tinyurl_notify_tinyuri(win, tiny_url);
return win;
}
settings = g_settings_new_with_backend(PREFS_SCHEMA,
purple_core_get_settings_backend());
tinyurl_prefix = g_settings_get_string(settings, PREF_URL);
g_object_unref(settings);
if (g_ascii_strncasecmp(uri, "http://", 7) && g_ascii_strncasecmp(uri, "https://", 8)) {
fullurl = g_strdup_printf("%shttp%%3A%%2F%%2F%s", tinyurl_prefix,
purple_url_encode(uri));
} else {
fullurl = g_strdup_printf("%s%s", tinyurl_prefix,
purple_url_encode(uri));
}
g_free(tinyurl_prefix);
/* Make a cancellable and cancel it when the window is destroyed, so that
* the callback does not try to use a non-existent window.
*/
cancellable = g_cancellable_new();
msg = soup_message_new("GET", fullurl);
g_object_set_data(G_OBJECT(msg), "gnttinyurl-window", win);
g_object_set_data_full(G_OBJECT(msg), "gnttinyurl-original", g_strdup(uri),
g_free);
soup_session_send_and_read_async(session, msg, G_PRIORITY_DEFAULT,
cancellable, tinyurl_notify_fetch_cb, msg);
g_signal_connect_object(win, "destroy", G_CALLBACK(g_cancellable_cancel),
cancellable, G_CONNECT_SWAPPED);
g_free(fullurl);
g_object_unref(cancellable);
return win;
}
static GPluginPluginInfo *
tiny_url_query(G_GNUC_UNUSED GError **error) {
const gchar * const authors[] = {
"Richard Nelson <wabz@whatsbeef.net>",
NULL
};
return finch_plugin_info_new(
"id", "TinyURL",
"name", N_("TinyURL"),
"version", DISPLAY_VERSION,
"category", N_("Utility"),
"summary", N_("TinyURL plugin"),
"description", N_("When receiving a message with URL(s), "
"use TinyURL for easier copying"),
"authors", authors,
"website", PURPLE_WEBSITE,
"abi-version", PURPLE_ABI_VERSION,
"settings-schema", PREFS_SCHEMA,
NULL
);
}
static gboolean
tiny_url_load(GPluginPlugin *plugin, G_GNUC_UNUSED GError **error) {
PurpleNotifyUiOps *ops = purple_notify_get_ui_ops();
session = soup_session_new();
g_object_set_data(G_OBJECT(plugin), "notify-uri", ops->notify_uri);
ops->notify_uri = tinyurl_notify_uri;
tinyurl_cache = g_hash_table_new_full(g_str_hash, g_str_equal,
g_free, g_free);
purple_signal_connect(purple_conversations_get_handle(),
"wrote-im-msg",
plugin, G_CALLBACK(wrote_msg), NULL);
purple_signal_connect(purple_conversations_get_handle(),
"wrote-chat-msg",
plugin, G_CALLBACK(wrote_msg), NULL);
purple_signal_connect(purple_conversations_get_handle(),
"writing-im-msg",
plugin, G_CALLBACK(writing_msg), NULL);
purple_signal_connect(purple_conversations_get_handle(),
"writing-chat-msg",
plugin, G_CALLBACK(writing_msg), NULL);
purple_signal_connect(purple_conversations_get_handle(),
"deleting-conversation",
plugin, G_CALLBACK(free_conv_urls), NULL);
return TRUE;
}
static gboolean
tiny_url_unload(GPluginPlugin *plugin, G_GNUC_UNUSED gboolean shutdown,
G_GNUC_UNUSED GError **error)
{
PurpleNotifyUiOps *ops = purple_notify_get_ui_ops();
if (ops->notify_uri == tinyurl_notify_uri)
ops->notify_uri = g_object_get_data(G_OBJECT(plugin), "notify-uri");
soup_session_abort(session);
g_clear_object(&session);
g_hash_table_destroy(tinyurl_cache);
tinyurl_cache = NULL;
return TRUE;
}
GPLUGIN_NATIVE_PLUGIN_DECLARE(tiny_url)