pidgin/pidgin
Clone
Summary
Browse
Changes
Graph
Fix unable to unblock XMPP buddy
release-2.x.y
2022-05-27, Belgin Știrbu
1912d331d78c
Fix unable to unblock XMPP buddy
If the user blocked an XMPP buddy that was not in the buddy list,
Pidgin sent the XID with the resource to the server's block list.
If the user tried to unblock that buddy after adding them to the
buddy list, Pidgin sent the XID without the resource to the server
for unblocking.
This resulted in users unable to unblock their buddies.
This patch fixes this situation by sending just the normalized XID
(i.e. without the resource) to the server for blocking and
unblocking.
Testing Done:
Tested on a Prosody XMPP server by adding a buddy and unblocking them.
Bugs closed: PIDGIN-16414
Reviewed at https://reviews.imfreedom.org/r/1479/
Pidgin
and
Finch
:
The
Universal
Chat
Clients
!
==========================================================================
For
a
complete
list
of
all
contributors
,
see
the
COPYRIGHT
file
.
We
've got an IRC room now too, #pidgin on irc.libera.chat. Come check us out.
Current Developers:
------------------
John '
rekkanoryo
' Bailey - Developer
Ethan '
Paco
-
Paco
' Blanton - Developer
Gary '
grim
' Kramlich - Developer
Richard '
rlaager
' Laager - Developer
Eion Robb - Developer
Elliott '
QuLogic
' Sales de Andrade - Developer
Crazy Patch Writers:
-------------------
Retired Developers:
------------------
Daniel '
datallah
' Atallah - Developer
Paul '
darkrain42
' Aurich - Developer
Herman Bloggs - Win32 Port
Thomas Butter - Developer
Ka-Hing Cheung - Developer
Sadrul Habib Chowdhury - Developer
Mark '
KingAnt
' Doliner - Developer
Jim Duchek <jim@linuxpimps.com> - maintainer
Sean Egan - Developer
Rob Flynn <gaim@robflynn.com> - maintainer
Adam Fritzler - libfaim maintainer
Christian '
ChipX86
' Hammond - Developer & Webmaster
Casey Harkins - Developer
Ivan Komarov - Developer
Syd Logan - hacker and designated driver [lazy bum]
Marcus '
malu
' Lundblad - Developer
Sulabh '
sulabh_m
' Mahajan - Developer
Richard '
wabz
' Nelson - Developer
Christopher '
siege
' O'
Brien
-
Developer
Bartosz
Oler
-
Developer
Etan
'deryni'
Reisner
-
Developer
Tim
'marv'
Ringenbach
-
Developer
Michael
'Maiku'
Ruprecht
-
Developer
,
voice
and
video
Luke
'LSchiere'
Schierer
-
Support
Megan
'Cae'
Schneider
-
support
/
QA
Evan
Schoenberg
-
Developer
Jim
Seymour
-
XMPP
developer
Mark
Spencer
<
markster
@marko
.
net
>
-
original
author
Kevin
'SimGuy'
Stange
-
Developer
&
Webmaster
Will
'resiak'
Thompson
-
Developer
Stu
'nosnilmot'
Tomlinson
-
Developer
Jorge
'Masca'
Villaseñor
-
Developer
Nathan
'faceprint'
Walp
-
Developer
Eric
Warmenhoven
<
eric
@warmenhoven
.
org
>
-
lead
developer
Tomasz
Wasilczyk
Retired
Crazy
Patch
Writers
:
---------------------------
Jakub
'haakon'
Adam
Felipe
'shx'
Contreras
Decklin
Foster
Krzysztof
Klinikowski
Peter
'Bleeter'
Lawler
Robert
'Robot101'
McQueen
Benjamin
Miller
Dennis
'EvilDennisR'
Ristuccia
-
Senior
Contributor
/
QA
Peter
'Fmoo'
Ruibal
Gabriel
'Nix'
Schulhof
Artists
:
-------
Hylke
Bons
-
Icons
Other
Contributions
:
-------------------
Much
thanks
to
Evan
Martin
<
martine
@cs
.
washington
.
edu
>
for
writing
GtkSpell
<
http
:
//
gtkspell
.
sourceforge
.
net
>
responsible
for
the
"Highlight misspelled words"
feature
and
for
gtk
-
nativewin
<
http
:
//
bunny
.
darktech
.
org
/
cvs
/
gtk
-
nativewin
/>
the
default
GTK
+-
2.0
engine
originally
used
in
our
win32
port
.
**
ORIGINAL
LOGO
DESIGNED
BY
:
Naru
Sundar
**
Peter
Teichiman
<
peter
@helixcode
.
com
>
Larry
Ewing
Jeramey
A
.
Crawford
Thanks
to
these
boys
.
Peter
and
Larry
managed
to
stomp
out
a
large
list
of
Mem
Leaks
.
Jeramey
found
the
remaining
onees
and
pointed
me
to
those
.
Props
to
the
boys
at
Helix
Code
.
Thanks
guys
.
Nathan
Walp
A
healthy
amount
of
patches
for
the
Jabber
plugin
Neil
Sanchala
Wrote
most
of
the
Zephyr
plugin
Arkadiusz
Miskiewicz
Wrote
the
Gadu
-
Gadu
plugin
David
Prater
<
IM
:
dRaven43
>
draven
@tcsx
.
net
Log
and
Colour
Button
Images
Sébastien
Carpe
<
IM
:
Seb
Carpe
>
Base
HTTP
Proxy
Support
Ari
Pollak
<
IM
:
Ari
Pollak
>
compwiz
.
dhs
.
org
Resize
conversation
window
patch
Decklin
Foster
Many
GUI
improvements
,
other
nifty
additions
and
fixes
David
<
IM
:
CrazyDavy
>
The
neato
-
bigger
text
box
S
D
Erle
Writing
a
cool
perl
script
to
translate
WinAIM
lists
to
gaim
BMiller
A
good
collection
of
stuff
.
%
n
for
away
messages
,
import
winaim
lists
,
pic
/
text
/
pic
+
text
for
buttons
,
among
others
Lance
Rocker
Improved
HTML
formatting
in
logs
,
plus
lots
of
debugging
on
*
BSD
.
ergofobe
:
GNOME
Url
handler
patch
Justin
M
.
Ward
<
justin
@yossman
.
net
>
:
Alphabetical
Away
Messages
patch
G
.
Sumner
Hayes
<
IM
:
SumnerFool
>
Security
Patches
Brian
Ryner
for
a
little
make
file
patch
:
)
Ryan
C
.
Gordon
-
I
still
think
you
look
like
Silent
Bob
.
Elliot
Tobin
<
elliot
@bha
.
udel
.
edu
>
Thanks
to
Jeroen
van
der
Vegt
for
the
initial
smiley
plugin
and
images
.
The
OpenQ
Team
Wrote
the
QQ
plugin
dropped
in
2.8.0
(
see
libpurple
/
qq
/
AUTHORS
in
2.7.11
)