It has always been vulnerable to MITM attacks when it is not used with DNSSEC,
and has been removed from XEP-0156 because of that. We have been issued
CVE-2022-26491 for this issue.
More discussion can be found at
https://mail.jabber.org/pipermail/standards/2022-February/038759.html.
Testing Done:
Compiled
Reviewed at https://reviews.imfreedom.org/r/1357/
/**
* @file network.c Network Implementation
* @ingroup core
*/
/* purple
*
* Purple is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA
*/
#include"internal.h"
#ifndef _WIN32
#include<arpa/nameser.h>
#include<resolv.h>
#include<netinet/in.h>
#include<net/if.h>
#include<sys/ioctl.h>
#ifdef HAVE_GETIFADDRS
#include<ifaddrs.h>
#endif
#else
#include<nspapi.h>
#endif
/* Solaris */
#if defined (__SVR4) && defined (__sun)
#include<sys/sockio.h>
#endif
#include"debug.h"
#include"account.h"
#include"nat-pmp.h"
#include"network.h"
#include"prefs.h"
#include"stun.h"
#include"upnp.h"
#include"dnsquery.h"
#ifdef USE_IDN
#include<idna.h>
#endif
#ifdef __HAIKU__
# ifndef SIOCGIFCONF
#include<sys/sockio.h>
# endif
#endif
/*
* Calling sizeof(struct ifreq) isn't always correct on
purple_debug_info("network","Received Network Change Notification. Current network count is %d, previous count was %d.\n",new_count,current_network_count);