pidgin/pidgin

Rewrite Bonjour SOCKS5 communication using Gio.

2020-11-14, Elliott Sales de Andrade
12ddbb897723
Rewrite Bonjour SOCKS5 communication using Gio.

* Remove XepXfer->rx_len, which is always 0.
* Rewrite Bonjour SOCKS5 communication using Gio.
The `bonjour_sock5_request_cb` function is confusing, incrementing `xf->sock5_req_state`, and then calling itself again to get to the next part of the switch. Using individual callback functions is required by Gio, but also hopefully clearer.

Testing Done:
Compile only.

Reviewed at https://reviews.imfreedom.org/r/215/
/* This file is part of the Project Athena Zephyr Notification System.
* It contains source for the ZFormatNotice function.
*
* Created by: Robert French
*
* Copyright (c) 1987,1988 by the Massachusetts Institute of Technology.
* For copying and distribution information, see the file
* "mit-copyright.h".
*/
#include "internal.h"
Code_t
ZFormatNotice(register ZNotice_t *notice, char **buffer, int *ret_len,
Z_AuthProc cert_routine)
{
char header[Z_MAXHEADERLEN];
int hdrlen;
Code_t retval;
if ((retval = Z_FormatHeader(notice, header, sizeof(header), &hdrlen,
cert_routine)) != ZERR_NONE)
return (retval);
*ret_len = hdrlen+notice->z_message_len;
/* Length can never be zero, don't have to worry about malloc(0). */
if (!(*buffer = (char *) malloc((unsigned)*ret_len)))
return (ENOMEM);
(void) memcpy(*buffer, header, hdrlen);
(void) memcpy(*buffer+hdrlen, notice->z_message, notice->z_message_len);
return (ZERR_NONE);
}