pidgin/pidgin

Fix transparency plugin for display list/pref changes

14 months ago, Elliott Sales de Andrade
04c0398f1046
Fix transparency plugin for display list/pref changes

There is no longer a buddy list/conversation split, so remove the duplicate settings (half of which were not used any more), and rename them without the differentiating prefix. Also, now that there's only one thing, there's no need for a second "enabled" setting in the plugin that just duplicates the plugin's enabled setting itself, so I removed it.

Instead of adding and removing a slider when the setting changes, I instead opted to always add it, and bind its visibility to the setting instead.

We no longer need a `gtk-config-frame` now that Pidgin uses GPlugin's plugin settings, so remove that and correctly wire up the settings schema so that GPlugin automatically displays settings.

Finally, the scale UI and alpha setting had different ranges. If the setting was moved below the scale's minimum, it would clamp it but not resend that value back to the setting, so things would appear inconsistent. To rectify this, I changed the setting's range up to match the scale.

Testing Done:
* Enabled Transparency plugin, changed around the transparency level and confirmed the main window became transparent.
* Toggled the solid-on-focus setting and confirmed the window lost transparency when focused.
* Toggled the slider setting and confirmed it was added/removed from the window.
* When slider was enabled, changed the setting and confirmed the slider changed and vice versa.

Reviewed at https://reviews.imfreedom.org/r/2394/
/*
* pidgin
*
* Pidgin is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA
*
*/
#include "purple.h"
#include <glib.h>
#include <glib/gprintf.h>
#include <glib/gi18n-lib.h>
#define G_SETTINGS_ENABLE_BACKEND
#include <gio/gsettingsbackend.h>
#include <signal.h>
#include <string.h>
#ifdef _WIN32
# include <conio.h>
#else
# include <unistd.h>
#endif
#include "test_ui.h"
/*** Conversation uiops ***/
static void
test_write_conv(PurpleConversation *conv, PurpleMessage *msg)
{
gchar *timestamp = purple_message_format_timestamp(msg, "(%H:%M:%S)");
printf("(%s) %s %s: %s\n",
purple_conversation_get_name(conv),
timestamp,
purple_message_get_author_alias(msg),
purple_message_get_contents(msg));
g_free(timestamp);
}
static PurpleConversationUiOps test_conv_uiops = {
.write_conv = test_write_conv
};
/******************************************************************************
* PurpleUi Implementation
*****************************************************************************/
struct _TestPurpleUi {
PurpleUi parent;
};
G_DECLARE_FINAL_TYPE(TestPurpleUi, test_purple_ui, TEST_PURPLE, UI, PurpleUi)
G_DEFINE_TYPE(TestPurpleUi, test_purple_ui, PURPLE_TYPE_UI)
static gboolean
test_purple_ui_start(G_GNUC_UNUSED PurpleUi *ui, G_GNUC_UNUSED GError **error) {
purple_conversations_set_ui_ops(&test_conv_uiops);
return TRUE;
}
static gpointer
test_purple_ui_get_settings_backend(G_GNUC_UNUSED PurpleUi *ui) {
return g_memory_settings_backend_new();
}
static void
test_purple_ui_init(G_GNUC_UNUSED TestPurpleUi *ui) {
}
static void
test_purple_ui_class_init(TestPurpleUiClass *klass) {
PurpleUiClass *ui_class = PURPLE_UI_CLASS(klass);
ui_class->start = test_purple_ui_start;
ui_class->get_settings_backend = test_purple_ui_get_settings_backend;
}
static PurpleUi *
test_purple_ui_new(void) {
return g_object_new(
test_purple_ui_get_type(),
"id", "test",
"name", "Test-UI",
"version", VERSION,
"website", PURPLE_WEBSITE,
"support-website", PURPLE_WEBSITE,
"client-type", "test",
NULL);
}
static gboolean
test_ui_init_history(GError **error) {
PurpleHistoryManager *manager = NULL;
PurpleHistoryAdapter *adapter = NULL;
const gchar *id = NULL;
manager = purple_history_manager_get_default();
adapter = purple_sqlite_history_adapter_new(":memory:");
id = purple_history_adapter_get_id(adapter);
if(!purple_history_manager_register(manager, adapter, error)) {
g_clear_object(&adapter);
return FALSE;
}
/* The manager adds a ref to the adapter on registration, so we can remove
* our reference.
*/
g_clear_object(&adapter);
return purple_history_manager_set_active(manager, id, error);
}
void
test_ui_purple_init(void) {
PurpleUi *ui = NULL;
GError *error = NULL;
#ifndef _WIN32
/* libpurple's built-in DNS resolution forks processes to perform
* blocking lookups without blocking the main process. It does not
* handle SIGCHLD itself, so if the UI does not you quickly get an army
* of zombie subprocesses marching around.
*/
signal(SIGCHLD, SIG_IGN);
#endif
/* set the magic PURPLE_PLUGINS_SKIP environment variable */
g_setenv("PURPLE_PLUGINS_SKIP", "1", TRUE);
ui = test_purple_ui_new();
/* Now that all the essential stuff has been set, let's try to init the core. It's
* necessary to provide a non-NULL name for the current ui to the core. This name
* is used by stuff that depends on this ui, for example the ui-specific plugins. */
if (!purple_core_init(ui, &error)) {
/* Initializing the core failed. Terminate. */
fprintf(stderr,
_("Initialization of the libpurple core failed. %s\n"
"Aborting!\nPlease report this!\n"),
(error != NULL) ? error->message : "unknown error");
g_clear_error(&error);
abort();
}
if(!test_ui_init_history(&error)) {
g_critical("failed to initialize the history api: %s",
error ? error->message : "unknown");
g_clear_error(&error);
}
/* Load the preferences. */
purple_prefs_load();
purple_prefs_add_none("/purple");
purple_prefs_add_none("/purple/test_ui");
purple_prefs_add_none("/purple/test_ui/plugins");
purple_prefs_add_path_list("/purple/test_ui/plugins/saved", NULL);
/* Load the desired plugins. The client should save the list of loaded plugins in
* the preferences using purple_plugins_save_loaded() */
purple_plugins_load_saved("/purple/test_ui/plugins/saved");
}
void
test_ui_purple_uninit(void) {
purple_core_quit();
}