pidgin/pidgin

Fix transparency plugin for display list/pref changes

13 months ago, Elliott Sales de Andrade
04c0398f1046
Fix transparency plugin for display list/pref changes

There is no longer a buddy list/conversation split, so remove the duplicate settings (half of which were not used any more), and rename them without the differentiating prefix. Also, now that there's only one thing, there's no need for a second "enabled" setting in the plugin that just duplicates the plugin's enabled setting itself, so I removed it.

Instead of adding and removing a slider when the setting changes, I instead opted to always add it, and bind its visibility to the setting instead.

We no longer need a `gtk-config-frame` now that Pidgin uses GPlugin's plugin settings, so remove that and correctly wire up the settings schema so that GPlugin automatically displays settings.

Finally, the scale UI and alpha setting had different ranges. If the setting was moved below the scale's minimum, it would clamp it but not resend that value back to the setting, so things would appear inconsistent. To rectify this, I changed the setting's range up to match the scale.

Testing Done:
* Enabled Transparency plugin, changed around the transparency level and confirmed the main window became transparent.
* Toggled the solid-on-focus setting and confirmed the window lost transparency when focused.
* Toggled the slider setting and confirmed it was added/removed from the window.
* When slider was enabled, changed the setting and confirmed the slider changed and vice versa.

Reviewed at https://reviews.imfreedom.org/r/2394/
/*
* finch
*
* Finch is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA
*/
#if !defined(FINCH_GLOBAL_HEADER_INSIDE) && !defined(FINCH_COMPILATION)
# error "only <finch.h> may be included directly"
#endif
#ifndef FINCH_CONV_H
#define FINCH_CONV_H
#include <gnt.h>
#include <purple.h>
/* Grabs the conv out of a PurpleConverstation */
#define FINCH_CONV(conv) ((FinchConv *)g_object_get_data(G_OBJECT(conv), "finch"))
/***************************************************************************
* GNT Conversations API
***************************************************************************/
typedef struct _FinchConv FinchConv;
typedef struct _FinchConvChat FinchConvChat;
typedef struct _FinchConvIm FinchConvIm;
/**
* FinchConversationFlag:
* @FINCH_CONV_NO_SOUND: A flag to mute a conversation.
*
* Flags that can be set for each conversation.
*/
typedef enum
{
FINCH_CONV_NO_SOUND = 1 << 0,
} FinchConversationFlag;
/**
* FinchConv:
* @list: A list of conversations being displayed in this window.
* @active_conv: The active conversation.
* @window: The #GntWindow for the conversation.
* @entry: The #GntEntry for input.
* @tv: The #GntTextView that displays the history.
* @menu: The menu for the conversation.
* @info: The info widget that shows the information about the conversation.
* @plugins: The #GntMenuItem for plugins.
* @flags: The flags for the conversation.
*
* A Finch conversation.
*/
struct _FinchConv
{
GList *list;
PurpleConversation *active_conv;
GntWidget *window; /* the container */
GntWidget *entry; /* entry */
GntWidget *tv; /* text-view */
GntWidget *menu;
GntWidget *info;
GntMenuItem *plugins;
FinchConversationFlag flags;
union
{
FinchConvChat *chat;
FinchConvIm *im;
} u;
};
/**
* FinchConvChat:
* @userlist: The widget that displays the users in the chat.
*
* The chat specific implementation for a conversation.
*/
struct _FinchConvChat
{
GntWidget *userlist; /* the userlist */
/*< private >*/
void *finch_reserved1;
void *finch_reserved2;
void *finch_reserved3;
void *finch_reserved4;
};
/**
* FinchConvIm:
* @sendto: The sendto widget which allows the user to select who they're
* messaging.
*
* The instant message implementation for a conversation.
*/
struct _FinchConvIm
{
GntMenuItem *sendto;
/*< private >*/
void *finch_reserved1;
void *finch_reserved2;
void *finch_reserved3;
void *finch_reserved4;
};
/**
* finch_conv_get_ui_ops:
*
* Get the ui-functions.
*
* Returns: The PurpleConversationUiOps populated with the appropriate functions.
*/
PurpleConversationUiOps *finch_conv_get_ui_ops(void);
/**
* finch_conversation_init:
*
* Perform the necessary initializations.
*/
void finch_conversation_init(void);
/**
* finch_conversation_uninit:
*
* Perform the necessary uninitializations.
*/
void finch_conversation_uninit(void);
/**
* finch_conversation_set_active:
* @conv: The conversation to make active.
*
* Set a conversation as active in a contactized conversation
*/
void finch_conversation_set_active(PurpleConversation *conv);
/**
* finch_conversation_set_info_widget:
* @conv: The conversation.
* @widget: The widget containing the information. If %NULL,
* the current information widget is removed.
*
* Sets the information widget for the conversation window.
*/
void finch_conversation_set_info_widget(PurpleConversation *conv, GntWidget *widget);
#endif /* FINCH_CONV_H */