pidgin/ljfisher-ssl-client-auth

Rename last_crt to prev cert. More comments.
cpw.ljfisher.ssl_client_auth
2012-10-08, Lucas Fisher
96ae7c4fe9ec
Parents a179e64cbcd0
Children d97cc2ae2ceb
Rename last_crt to prev cert. More comments.
1 files changed, 9 insertions(+), 6 deletions(-)
  • +9 -6
    libpurple/certificate.c
    • --- a/libpurple/certificate.c Mon Jul 09 21:10:17 2012 -0400
    +++ b/libpurple/certificate.c Mon Oct 08 17:59:34 2012 -0400
    @@ -690,24 +690,27 @@
    is_valid_crt_chain(GList *crts)
    {
    PurpleCertificate *crt = NULL;
    - PurpleCertificate *last_crt = NULL;
    + PurpleCertificate *prev_crt = NULL;
    GList *item = NULL;
    gchar *unique_id = NULL;
    gchar *issuer_unique_id = NULL;
    gboolean good = TRUE;
    - /* Check if certs are in the correct order */
    + /* Check if certs are in the correct order.
    + The end user's cert should be first. Each cert should be
    + followed by the certificate belonging to its issuer.
    + */
    item = g_list_first(crts);
    - last_crt = (PurpleCertificate*)item->data;
    - g_return_val_if_fail(NULL != last_crt, FALSE);
    + prev_crt = (PurpleCertificate*)item->data;
    + g_return_val_if_fail(NULL != prev_crt, FALSE);
    item = g_list_next(item);
    while (NULL != item && good) {
    crt = (PurpleCertificate*)item->data;
    g_return_val_if_fail(NULL != crt, FALSE);
    unique_id = purple_certificate_get_unique_id(crt);
    - issuer_unique_id = purple_certificate_get_issuer_unique_id(last_crt);
    + issuer_unique_id = purple_certificate_get_issuer_unique_id(prev_crt);
    if (0 != g_strcmp0(unique_id, issuer_unique_id)) {
    purple_debug_error("certificate", "Broken certificate chain: %s %s\n",
    @@ -717,7 +720,7 @@
    g_free(unique_id);
    g_free(issuer_unique_id);
    - last_crt = crt;
    + prev_crt = crt;
    item = g_list_next(item);
    }