HGKeeper

jabber: Treat empty <group/> elements as "Buddies", not ""

2011-05-11, Paul Aurich

9725839f5a19

jabber: Treat empty elements as "Buddies", not ""

This ultimately led to duplicates in the list, because
we had one entry in the GSList as "", and one as NULL, both of which are
invalid group names, which resulted in the core blithely replacing
them with "Buddies" and generating duplicates.

I've tested with and without, and can reproduce the issues without the change.

Log:

(19:32:23) jabber: jabber_roster_parse(): Removing person@example.com from group 'Buddies' on the local list
(19:32:23) GLib: g_string_append: assertion `val != NULL' failed
(19:32:23) jabber: jabber_roster_parse(): Adding person@example.com to groups: ,
(19:32:23) g_log: purple_find_group: assertion `(name != NULL) && (*name != '\0')' failed
(19:32:23) g_log: purple_group_new: assertion `name != NULL' failed
(19:32:23) g_log: purple_blist_add_group: assertion `group != NULL' failed
(19:32:23) g_log: purple_find_group: assertion `(name != NULL) && (*name != '\0')' failed
(19:32:23) g_log: purple_group_new: assertion `*name != '\0'' failed
(19:32:23) g_log: purple_blist_add_group: assertion `group != NULL' failed

Since I had to look it up, purple_blist_add_buddy replaces (group == NULL) with "Buddies".

For information on writing a plugin for Purple, Pidgin or Finch, go

http://developer.pidgin.im and click on API. From there, see the

HOWTOs in the "Related Pages" section.

You can also generate this documentation locally by installing

doxygen and graphviz dot, then running "make docs" in the

source tree. The documentation will be in the docs/html directory.

pidgin/ljfisher-ssl-client-auth