pidgin/android/libpurple

Bounds-check stringref copies (which are safe anyway)

2011-08-17, Ethan Blanton
7d8e1af031fe
Parents 039186f7fc5b
Children 9239fec54684
Bounds-check stringref copies (which are safe anyway)
1 files changed, 5 insertions(+), 2 deletions(-)
  • +5 -2
    libpurple/stringref.c
    • --- a/libpurple/stringref.c Wed Aug 17 22:00:37 2011 +0000
    +++ b/libpurple/stringref.c Wed Aug 17 23:54:59 2011 +0000
    @@ -65,12 +65,15 @@
    PurpleStringref *purple_stringref_new(const char *value)
    {
    PurpleStringref *newref;
    + size_t len;
    if (value == NULL)
    return NULL;
    - newref = g_malloc(sizeof(PurpleStringref) + strlen(value));
    - strcpy(newref->value, value);
    + len = strlen(value);
    +
    + newref = g_malloc(sizeof(PurpleStringref) + len);
    + g_strlcpy(newref->value, value, len);
    newref->ref = 1;
    return newref;