pidgin/android/libpurple

Add TODOs to escape filenames. I don't think these are severe problems,

2013-02-18, Mark Doliner
7415482377b5
Parents 925e38bc31b5
Children d7b8bff10713
Add TODOs to escape filenames. I don't think these are severe problems,
just minor UI bugs.
2 files changed, 16 insertions(+), 0 deletions(-)
  • +8 -0
    libpurple/protocols/gg/image.c
  • +8 -0
    libpurple/protocols/sametime/sametime.c
    • --- a/libpurple/protocols/gg/image.c Mon Feb 18 17:27:38 2013 -0800
    +++ b/libpurple/protocols/gg/image.c Mon Feb 18 17:59:15 2013 -0800
    @@ -177,6 +177,14 @@
    gchar *imgtag_replace;
    GList *pending_messages_it;
    + /* TODO: This PurpleStoredImage will be rendered within the IM window
    + and right-clicking the image will allow the user to save the image
    + to disk. The default filename used in this dialog is the filename
    + that we pass to purple_imgstore_new_with_id(), so we should call
    + g_path_get_basename() and purple_escape_filename() on it before
    + passing it in. This is easy, but it's not clear if there might be
    + other implications because this filename is used elsewhere within
    + this PRPL. */
    stored_id = purple_imgstore_new_with_id(
    g_memdup(image_reply->image, image_reply->size),
    image_reply->size,
    --- a/libpurple/protocols/sametime/sametime.c Mon Feb 18 17:27:38 2013 -0800
    +++ b/libpurple/protocols/sametime/sametime.c Mon Feb 18 17:59:15 2013 -0800
    @@ -2780,6 +2780,14 @@
    cid = make_cid(cid);
    /* add image to the purple image store */
    + /* TODO: This PurpleStoredImage will be rendered within the IM window
    + and right-clicking the image will allow the user to save the image
    + to disk. The default filename used in this dialog is the filename
    + that we pass to purple_imgstore_new_with_id(), so we should call
    + g_path_get_basename() and purple_escape_filename() on it before
    + passing it in. This is easy, but it's not clear if there might be
    + other implications because this filename is used elsewhere within
    + this PRPL. */
    img = purple_imgstore_new_with_id(d_dat, d_len, cid);
    /* map the cid to the image store identifier */