pidgin/android/libpurple

MXit: Fix compiler warnings related to "comparison between signed and unsigned integer expressions".
release-2.x.y
2013-04-03, Andrew Victor
53109a1846ae
Parents e8edfd4e26ae
Children de99b599db24
MXit: Fix compiler warnings related to "comparison between signed and unsigned integer expressions".

cipher.c:131:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
cipher.c:179:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
cipher.c:230:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
markup.c:295:45: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
markup.c:298:45: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
markup.c:660:14: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
roster.c:678:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
3 files changed, 24 insertions(+), 24 deletions(-)
  • +16 -16
    libpurple/protocols/mxit/cipher.c
  • +7 -7
    libpurple/protocols/mxit/markup.c
  • +1 -1
    libpurple/protocols/mxit/roster.c
    • --- a/libpurple/protocols/mxit/cipher.c Wed Apr 03 00:36:03 2013 +0200
    +++ b/libpurple/protocols/mxit/cipher.c Wed Apr 03 00:49:23 2013 +0200
    @@ -107,12 +107,12 @@
    */
    char* mxit_encrypt_password( struct MXitSession* session )
    {
    - char key[16 + 1];
    - char exkey[512];
    - GString* pass = NULL;
    - GString* encrypted = NULL;
    - char* base64;
    - int i;
    + char key[16 + 1];
    + char exkey[512];
    + GString* pass = NULL;
    + GString* encrypted = NULL;
    + char* base64;
    + unsigned int i;
    purple_debug_info( MXIT_PLUGIN_ID, "mxit_encrypt_password\n" );
    @@ -154,11 +154,11 @@
    */
    char* mxit_decrypt_message( struct MXitSession* session, char* message )
    {
    - guchar* raw_message;
    - gsize raw_len;
    - char exkey[512];
    - GString* decoded = NULL;
    - int i;
    + guchar* raw_message;
    + gsize raw_len;
    + char exkey[512];
    + GString* decoded = NULL;
    + unsigned int i;
    /* remove optional header: <mxitencrypted ver="5.2"/> */
    if ( strncmp( message, ENCRYPT_HEADER, strlen( ENCRYPT_HEADER ) ) == 0 )
    @@ -209,11 +209,11 @@
    */
    char* mxit_encrypt_message( struct MXitSession* session, char* message )
    {
    - GString* raw_message = NULL;
    - char exkey[512];
    - GString* encoded = NULL;
    - gchar* base64;
    - int i;
    + GString* raw_message = NULL;
    + char exkey[512];
    + GString* encoded = NULL;
    + gchar* base64;
    + unsigned int i;
    purple_debug_info( MXIT_PLUGIN_ID, "encrypt message: '%s'\n", message );
    --- a/libpurple/protocols/mxit/markup.c Wed Apr 03 00:36:03 2013 +0200
    +++ b/libpurple/protocols/mxit/markup.c Wed Apr 03 00:49:23 2013 +0200
    @@ -249,12 +249,12 @@
    {
    GString* msg = NULL;
    char* ch = NULL;
    - int pos = 0;
    - int start = 0;
    - int l_nl = 0;
    - int l_sp = 0;
    - int l_gt = 0;
    - int stop = 0;
    + unsigned int pos = 0;
    + unsigned int start = 0;
    + unsigned int l_nl = 0;
    + unsigned int l_sp = 0;
    + unsigned int l_gt = 0;
    + unsigned int stop = 0;
    int tags = 0;
    gboolean intag = FALSE;
    @@ -651,7 +651,7 @@
    */
    static int mxit_parse_vibe( struct RXMsgData* mx, const char* message )
    {
    - int vibeid;
    + unsigned int vibeid;
    vibeid = message[2] - '0';
    --- a/libpurple/protocols/mxit/roster.c Wed Apr 03 00:36:03 2013 +0200
    +++ b/libpurple/protocols/mxit/roster.c Wed Apr 03 00:49:23 2013 +0200
    @@ -672,7 +672,7 @@
    {
    struct contact* con = NULL;
    struct contact* match = NULL;
    - int i;
    + unsigned int i;
    /* run through all the invites and try and find the match */
    for ( i = 0; i < g_list_length( session->invites ); i++ ) {