pidgin/android/libpurple

Add a missing break. I think maybe this was found by Coverity.
release-2.x.y
2013-02-18, Mark Doliner
0508b089c8ee
Parents 41d15beb309a
Children 5e1a2b90561c
Add a missing break. I think maybe this was found by Coverity.
I'm not sure if this caused harm. If it did, it would be something like:
1. You tried adding a buddy on oscar
2. It failed because you have too many items in your list
3. We sent an authorization request to the buddy

But maybe the auth request would have been ignored? Auth requests
aren't used for AIM, and for ICQ you maybe would have already sent
an auth request, or you would need to send one in the future anyway,
so not a big deal.
1 files changed, 1 insertions(+), 1 deletions(-)
  • +1 -1
    libpurple/protocols/oscar/oscar.c
    • --- a/libpurple/protocols/oscar/oscar.c Wed Feb 13 07:13:30 2013 -0800
    +++ b/libpurple/protocols/oscar/oscar.c Mon Feb 18 21:37:00 2013 -0800
    @@ -4180,7 +4180,7 @@
    if ((retval->name != NULL) && !purple_conv_present_error(retval->name, purple_connection_get_account(gc), buf))
    purple_notify_error(gc, NULL, _("Unable to Add"), buf);
    g_free(buf);
    - }
    + } break;
    case 0x000e: { /* buddy requires authorization */
    if ((retval->action == SNAC_SUBTYPE_FEEDBAG_ADD) && (retval->name))