grim/pidgin

Remove the unit test checking if purple_contact_info_matches can match an id

16 months ago, Gary Kramlich
9f922bd66563
Parents 34db408e4e3c
Children b9dc817fbb3f
Remove the unit test checking if purple_contact_info_matches can match an id

Originally we had purple_contact_info_matches checking id's for stuff like IRC,
but for protocols that use UUID's you start getting weird matches if because
searching for `af` can very easily match a UUID and isn't what the user would
expect.

Testing Done:
Ran the unit tests and verified they pass again.

Reviewed at https://reviews.imfreedom.org/r/2241/
1 files changed, 0 insertions(+), 11 deletions(-)
  • +0 -11
    libpurple/tests/test_contact_info.c
    • --- a/libpurple/tests/test_contact_info.c Fri Feb 17 19:41:15 2023 -0600
    +++ b/libpurple/tests/test_contact_info.c Sun Feb 19 04:11:37 2023 -0600
    @@ -336,15 +336,6 @@
    }
    static void
    -test_purple_contact_info_matches_id(void) {
    - PurpleContactInfo *info = purple_contact_info_new("this is an id");
    -
    - g_assert_true(purple_contact_info_matches(info, "an"));
    -
    - g_clear_object(&info);
    -}
    -
    -static void
    test_purple_contact_info_matches_username(void) {
    PurpleContactInfo *info = purple_contact_info_new(NULL);
    @@ -432,8 +423,6 @@
    test_purple_contact_info_matches_accepts_null);
    g_test_add_func("/contact-info/matches/emptry_string",
    test_purple_contact_info_matches_empty_string);
    - g_test_add_func("/contact-info/matches/id",
    - test_purple_contact_info_matches_id);
    g_test_add_func("/contact-info/matches/username",
    test_purple_contact_info_matches_username);
    g_test_add_func("/contact-info/matches/alias",