grim/govcs

Remove Bookmark from the vcs interface and the git implementation
draft
2017-12-05, Gary Kramlich
e440547e16c0
Parents d1ffff2d3d6d
Children 568998f4ffe3
Remove Bookmark from the vcs interface and the git implementation
2 files changed, 0 insertions(+), 10 deletions(-)
  • +0 -9
    git/git_test.go
  • +0 -1
    vcs/vcs.go
    • --- a/git/git_test.go Tue Dec 05 00:06:35 2017 -0600
    +++ b/git/git_test.go Tue Dec 05 20:24:15 2017 -0600
    @@ -86,15 +86,6 @@
    Expect(git.Branch()).To(Equal("my-fancy-branch"))
    }
    -// Git doesn't implement bookmark so make sure it is always empty
    -func (s *gitSuite) TestBookmark(t sweet.T) {
    - backend := s.setup(exec.NewMockCommand("my-fancy-bookmark", nil))
    - defer exec.SetBackend(backend)
    -
    - git := Git{}
    - Expect(git.Bookmark()).To(Equal(""))
    -}
    -
    func (s *gitSuite) TestConfigUserEmail(t sweet.T) {
    backend := s.setup(exec.NewMockCommand("grim@reaperworld.com\n", nil))
    defer exec.SetBackend(backend)
    --- a/vcs/vcs.go Tue Dec 05 00:06:35 2017 -0600
    +++ b/vcs/vcs.go Tue Dec 05 20:24:15 2017 -0600
    @@ -5,6 +5,5 @@
    Commit() string
    ShortCommit() string
    Branch() string
    - Bookmark() string
    Config(key string) []string
    }