grim/convey

Fix some minor linting issues

5 months ago, Elliott Sales de Andrade
62cc853bf396
Fix some minor linting issues

Testing Done:
Ran `golint`, saw fewer lints, and ran `go build .`

Reviewed at https://reviews.imfreedom.org/r/2869/
//go:build !windows
package script
import (
"testing"
"github.com/stretchr/testify/assert"
"keep.imfreedom.org/grim/convey/yaml"
)
func TestShellDefaults(t *testing.T) {
s := &Shell{
Filename: "/dev/null",
}
s.Valid()
assert.Equal(t, s.Shell, "/bin/sh")
}
func TestShellCommands(t *testing.T) {
s := &Shell{
Commands: yaml.StringOrSlice{"uptime"},
}
assert.NoError(t, s.Valid())
}
func TestShellFilename(t *testing.T) {
s := &Shell{
Filename: "/dev/null",
}
assert.NoError(t, s.Valid())
}
func TestShellNeitherFilenameNorCommands(t *testing.T) {
s := &Shell{}
assert.ErrorIs(t, s.Valid(), ErrNoCommandsOrFilename)
}
func TestShellBothFilenameAndCommands(t *testing.T) {
s := &Shell{
Commands: yaml.StringOrSlice{"uptime"},
Filename: "/dev/null",
}
assert.ErrorIs(t, s.Valid(), ErrOnlyFilenameOrCommands)
}