grim/containers/reviewboard

Remove more unnecessary stuff

14 months ago, Gary Kramlich
79afbf32c993
Parents 5921261aa12e
Children 915dda3d764e
Remove more unnecessary stuff
3 files changed, 0 insertions(+), 36 deletions(-)
  • +0 -2
    Dockerfile
  • +0 -31
    saml-fullname.patch
  • +0 -3
    tzdata.selections
    • --- a/Dockerfile Wed Mar 22 01:38:18 2023 -0500
    +++ b/Dockerfile Wed Mar 22 02:01:03 2023 -0500
    @@ -1,7 +1,5 @@
    FROM docker.io/beanbag/reviewboard:5.0.3 AS app
    -COPY tzdata.selections /
    -
    # install rbjbhub
    RUN set -ex && \
    pip install --no-cache rbjbhub
    --- a/saml-fullname.patch Wed Mar 22 01:38:18 2023 -0500
    +++ /dev/null Thu Jan 01 00:00:00 1970 +0000
    @@ -1,31 +0,0 @@
    -diff --git a/reviewboard/accounts/sso/backends/saml/views.py b/reviewboard/accounts/sso/backends/saml/views.py
    -index 5b6397a1b..f792d8dca 100644
    ---- a/reviewboard/accounts/sso/backends/saml/views.py
    -+++ b/reviewboard/accounts/sso/backends/saml/views.py
    -@@ -328,6 +328,26 @@ class SAMLACSView(SAMLViewMixin, BaseSSOView):
    - if value and isinstance(value, list):
    - return value[0]
    -
    -+ if key in ('User.FirstName', 'User.LastName'):
    -+ try:
    -+ fullname = self._get_user_attr_value(auth, 'User.FullName')
    -+ except KeyError:
    -+ # Just raise the KeyError with the original key, as
    -+ # KeyError.__str__ will quote the entire parameter. So if we
    -+ # tried to append 'User.FullName` we would output something like
    -+ # "'User.FullName or User.LastName'" instead of
    -+ # "'User.FullName' or 'User.LastName'".
    -+ raise KeyError(key)
    -+
    -+ # we don't have a good way to split the username to a first
    -+ # name/last name, so we split on the first space and then treat the
    -+ # two parts as the first and last names.
    -+ name_parts = fullname.split(' ', 1)
    -+ if key == 'User.FirstName':
    -+ return name_parts[0]
    -+ else:
    -+ return len(name_parts) > 1 and name_parts[1] or ''
    -+
    - raise KeyError(key)
    -
    -
    --- a/tzdata.selections Wed Mar 22 01:38:18 2023 -0500
    +++ /dev/null Thu Jan 01 00:00:00 1970 +0000
    @@ -1,3 +0,0 @@
    -tzdata tzdata/Zones/Etc select UTC
    -tzdata tzdata/Areas select Etc
    -