gplugin/gplugin

Delete the comments explaining the handling of gplugin_version_compare and it makes a lot more sense now
feature/fix-gplugin-version-compare
2020-02-23, Gary Kramlich
a176f6409f92
Parents 6f86bf95410b
Children a2286e7ed942
Delete the comments explaining the handling of gplugin_version_compare and it makes a lot more sense now
1 files changed, 0 insertions(+), 9 deletions(-)
  • +0 -9
    gplugin/gplugin-manager.c
    • --- a/gplugin/gplugin-manager.c Sun Feb 23 04:41:36 2020 -0600
    +++ b/gplugin/gplugin-manager.c Sun Feb 23 19:41:17 2020 -0600
    @@ -1339,20 +1339,11 @@
    }
    if(result < 0) {
    - /* negative values mean that the first version is larger than the
    - * second, so we need check for > and >=.
    - */
    keep = (g_strcmp0(op, "<") == 0 || g_strcmp0(op, "<=") == 0);
    } else if(result == 0) {
    - /* 0 values mean we need to check for = and ==, as well as <= and
    - * >= as they need to match too.
    - */
    keep = (g_strcmp0(op, "=") == 0 || g_strcmp0(op, "==") == 0 ||
    g_strcmp0(op, "<=") == 0 || g_strcmp0(op, ">=") == 0);
    } else if(result > 0) {
    - /* positive values mean that the first version is smaller than the
    - * second, so we need to check for < and <=.
    - */
    keep = (g_strcmp0(op, ">") == 0 || g_strcmp0(op, ">=") == 0);
    }