gplugin/gplugin

Fix an invalid read that valgrind detected and that we ignored from pvs-studio
bugfix/valgrind-catchup
2020-02-27, Gary Kramlich
06d9506c1030
Parents 7fcc318d3d11
Children 881e8e613d6c
Fix an invalid read that valgrind detected and that we ignored from pvs-studio
1 files changed, 2 insertions(+), 1 deletions(-)
  • +2 -1
    gplugin/gplugin-manager.c
    • --- a/gplugin/gplugin-manager.c Thu Feb 27 02:36:58 2020 -0600
    +++ b/gplugin/gplugin-manager.c Thu Feb 27 02:42:09 2020 -0600
    @@ -559,6 +559,7 @@
    real_filename);
    error_messages =
    g_list_prepend(error_messages, error_message);
    + continue;
    }
    /* now insert into our view */
    @@ -570,7 +571,7 @@
    /* Grab the list of plugins with our id and prepend the new
    * plugin to it before updating it.
    */
    - l = g_hash_table_lookup(manager->plugins, id); //-V1004
    + l = g_hash_table_lookup(manager->plugins, id);
    for(ll = l; ll; ll = ll->next) {
    GPluginPlugin *splugin = GPLUGIN_PLUGIN(ll->data);
    gchar *sfilename = gplugin_plugin_get_filename(splugin);