gplugin/gplugin

Split plugin details into a separate page

19 months ago, Elliott Sales de Andrade
fcd52dc4273e
Split plugin details into a separate page

This modifies the `GPluginGtkView` into a stack, showing the list of plugins by default (called the 'overview'), or a page for a specific plugin. Going back and forth is automated, but an application can request the page for a plugin directly if needed.

The plugin row no longer expands to show details or shows a config button, but its activation goes to its own page now. This also makes each row a bit more balanced vertically, since there's no `GtkRevealer` taking up invisible space underneath.

The new plugin page is _mostly_ a copy of the previous plugin row, except:

* It's always expanded (or rather, it cannot be collapsed.)
* The main details are re-arranged a bit to fit nicely on a page.
* All information is found via `GtkExpression`s.
* Instead of separate labels for each author/dependency, these are now a single newline-separated label, which is easier to generate.
* Booleans display a check mark instead of text, like in the inspector.
* Information labels are selectable and have a `labelled-by` relation.
* The error message is allowed to wrap.

Settings, once implemented, can go at the end of this page.

I debated splitting the plugin info into a stack with 'important' vs 'developer-oriented' entries (somewhat how `GtkAboutDialog` splits its information), but that can go in a separate review if it's done.

NOTE: This deletes the `expanded` property from `GPluginGtkPluginRow`; that's probably an ABI break, though /r/1834 means it was never registered in a released version.

Testing Done:
Opened the separate page of a few plugins, and saw that details were available. Also, the switch was in sync with the switch in the overview.

Reviewed at https://reviews.imfreedom.org/r/1840/
## clang-format
GPlugin uses [clang-format][1] to automatically format code. Version 9 (or
higher) is required. Earlier versions will fail on the options in the
`.clang-format` file.
You can use clang-format in one or more of the following ways:
* Integrate it into your editor. The [clang-format page][1] has examples.
* Use a Mercurial [hook script][2].
* Run `ninja clang-format` from your build directory.
* Worst case, run `clang-format -i SOME_FILE` manually.
### GObject Functions
GObject and GPlugin have functions which take pairs of name/value arguments:
* `g_object_get()`
* `g_object_new()`
* `gplugin_plugin_info_new()`
If code calling one of these functions with such pairs has to be wrapped, the
pairs are easier to read and edit with manual formatting to group the name and
value on the same line (but otherwise following the usual formatting that
clang-format would apply):
```
/* clang-format off */
g_object_get(
G_OBJECT(info),
"name", &name,
"summary", &summary,
NULL);
/* clang-format on */
```
### Debian
Debian and derivatives (e.g. Ubuntu) ship clang-format version 9 in a package
named `clang-format-9`. The package named `clang-format` is currently an
older version. Additionally, the `clang-format-9` package will not place a
`clang-format` in the `$PATH`. Install as follows:
```
sudo apt install clang-format-9
sudo update-alternatives --set clang-format /usr/bin/clang-format-9
```
## convey
GPlugin uses [Convey][3] for CI. You can run the integration tests locally.
To initially setup Convey, which requires Docker:
1. Install Convey. You can use a pre-built binary from [convey's Downloads
page][4]; put that (or a symlink) in your `$PATH` named `convey`.
For now, avoid version 0.14.
2. Install Docker. On Debian systems, use: `sudo apt install docker.io`
3. Add yourself to the `docker` group. Adding yourself to a group does not
add that group to your existing session, so the first time you will need to
get a shell in that group with `newgrp docker` or by rebooting.
To run all of the integration tests, run the "all" metaplan:
```
convey all
```
To run a specific test/platform, run the plan directly:
```
convey alpine-edge-amd64
```
To get a list of metaplans and their plans:
```
convey list metaplans
```
[1]: https://clang.llvm.org/docs/ClangFormat.html
[2]: https://hg.mozilla.org/projects/nss/file/default/coreconf/precommit.clang-format.sh
[3]: https://keep.imfreedom.org/grim/convey
[4]: https://bintray.com/pidgin/releases/convey