gplugin/gplugin

Bring back the break after functions
develop
2020-02-15, Richard Laager
d87c806b1f05
Bring back the break after functions

With the AlwaysBreak style, functions with many arguments get continued
onto the next line like this:

gplugin_gtk_store_plugin_unloaded_cb(
GObject *manager,
GPluginPlugin *plugin,
gpointer data) {
gplugin_gtk_store_update_plugin_state(
GPLUGIN_GTK_STORE(data), plugin);
}

It is difficult to see where parameters stop and the body starts.

Gary suggested this formatting, which "helps (at least me) visually see
the blocks while scanning the code":

gplugin_gtk_store_plugin_unloaded_cb(
GObject *manager,
GPluginPlugin *plugin,
gpointer data
) {
gplugin_gtk_store_update_plugin_state(
GPLUGIN_GTK_STORE(data), plugin);
}

Unfortunately, that is not something that clang-format supports. We
can get almost the same output (just moving the closing paren), with
the same visual benefits, by using BraceWrapping: AfterFunction: true,
which produces this:

gplugin_gtk_store_plugin_unloaded_cb(
GObject *manager,
GPluginPlugin *plugin,
gpointer data)
{
gplugin_gtk_store_update_plugin_state(
GPLUGIN_GTK_STORE(data), plugin);
}
if get_option('gtk3')
gplugin_gtk_viewer_resources = gnome.compile_resources(
'gplugin-gtk-viewer-resources',
'data/gplugin-gtk-viewer.gresource.xml',
c_name: 'gplugin_gtk_viewer',
source_dir: 'data')
gplugin_gtk_viewer = executable('gplugin-gtk-viewer',
'gplugin-gtk-viewer.c',
'gplugin-gtk-viewer-window.c',
'gplugin-gtk-viewer-window.h',
dependencies : [gplugin_dep, gplugin_gtk_dep],
install : true
)
if get_option('help2man')
gplugin_gtk_viewer_man = custom_target('gplugin-gtk-viewer.1',
command : [help2man,
'--name=View installed plugins', '--section=1',
'--help-option=--help-all', '--no-info',
'--output', '@OUTPUT@',
gplugin_gtk_viewer],
output : 'gplugin-gtk-viewer.1',
install : true,
install_dir : join_paths(get_option('mandir'), 'man1'))
endif
endif