gplugin/gplugin

fix memory leaks in gplugin_file_source

14 months ago, Markus Fischer
d821f171d4c6
fix memory leaks in gplugin_file_source

leaks encountered:
## libpurple test_contact_info and test_person
```
==5998== 16 bytes in 1 blocks are definitely lost in loss record 1,996 of 6,277
==5998== at 0x48417E4: malloc (vg_replace_malloc.c:393)
==5998== by 0x4A6FA18: g_malloc (in /usr/lib64/libglib-2.0.so.0.7400.4)
==5998== by 0x4A88540: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.7400.4)
==5998== by 0x4A89675: g_slist_prepend (in /usr/lib64/libglib-2.0.so.0.7400.4)
==5998== by 0x4F0DA9E: gplugin_file_source_add_loader (gplugin-file-source.c:112)
==5998== by 0x4F0DCF1: gplugin_file_source_update_loaders (gplugin-file-source.c:179)
==5998== by 0x4F0E971: gplugin_file_source_constructed (gplugin-file-source.c:524)
==5998== by 0x49CF002: ??? (in /usr/lib64/libgobject-2.0.so.0.7400.4)
==5998== by 0x49D0C33: g_object_new_valist (in /usr/lib64/libgobject-2.0.so.0.7400.4)
==5998== by 0x49D1250: g_object_new (in /usr/lib64/libgobject-2.0.so.0.7400.4)
==5998== by 0x4F0EC51: gplugin_file_source_new (gplugin-file-source.c:607)
==5998== by 0x4F08019: gplugin_manager_refresh (gplugin-manager.c:874)
```
## gplugin tests
```
==23357== 456 (16 direct, 440 indirect) bytes in 1 blocks are definitely lost in loss record 535 of 557
==23357== at 0x48417E4: malloc (vg_replace_malloc.c:393)
==23357== by 0x48E4828: g_malloc (in /usr/lib64/libglib-2.0.so.0.7400.5)
==23357== by 0x48FD281: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.7400.5)
==23357== by 0x48FE6A8: g_slist_copy_deep (in /usr/lib64/libglib-2.0.so.0.7400.5)
==23357== by 0x485B252: gplugin_manager_find_plugins (gplugin-manager.c:934)
==23357== by 0x4861216: gplugin_file_source_scan (gplugin-file-source.c:349)
==23357== by 0x48622A9: gplugin_source_scan (gplugin-source.c:66)
==23357== by 0x485B041: gplugin_manager_refresh (gplugin-manager.c:881)
==23357== by 0x109464: test_gplugin_init_uninit_with_double_refresh_plugins (test-core.c:115)
==23357== by 0x49079DD: ??? (in /usr/lib64/libglib-2.0.so.0.7400.5)
==23357== by 0x490774C: ??? (in /usr/lib64/libglib-2.0.so.0.7400.5)
==23357== by 0x4907EE1: g_test_run_suite (in /usr/lib64/libglib-2.0.so.0.7400.5)
```

Testing Done:
Ran all gplugin tests and test_contact_info and test_person from libpurple in valgrind without encountering above leaks or any invalid reads/writes.

Reviewed at https://reviews.imfreedom.org/r/2255/
/*
* Copyright (C) 2011-2020 Gary Kramlich <grim@reaperworld.com>
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, see <https://www.gnu.org/licenses/>.
*/
#include <glib/gi18n-lib.h>
#include <gplugin.h>
#include <gplugin-native.h>
#include "gplugin-lua-loader.h"
#include "gplugin-lua-plugin.h"
static GPluginLoader *loader = NULL;
static GPluginPluginInfo *
gplugin_lua_query(G_GNUC_UNUSED GError **error)
{
/* clang-format-11 formats this correctly, so this can be removed then. */
/* clang-format off */
const gchar *const authors[] = {
"Gary Kramlich <grim@reaperworld.com>",
NULL};
/* clang-format on */
/* clang-format off */
return gplugin_plugin_info_new(
"gplugin/lua-loader",
GPLUGIN_NATIVE_PLUGIN_ABI_VERSION,
"internal", TRUE,
"auto-load", TRUE,
"name", "Lua Plugin Loader",
"version", GPLUGIN_VERSION,
"license-id", "LGPL-2.0-or-later",
"summary", "A plugin that can load Lua plugins",
"description", "This plugin allows the loading of plugins written in "
"the Lua programming language.",
"authors", authors,
"website", GPLUGIN_WEBSITE,
"category", "loaders",
"bind-global", TRUE,
"unloadable", FALSE,
NULL);
/* clang-format on */
}
static gboolean
gplugin_lua_load(GPluginPlugin *plugin, GError **error)
{
GPluginManager *manager = NULL;
manager = gplugin_manager_get_default();
gplugin_lua_loader_register(G_TYPE_MODULE(plugin));
gplugin_lua_plugin_register(G_TYPE_MODULE(plugin));
loader = gplugin_lua_loader_new();
if(!gplugin_manager_register_loader(manager, loader, error)) {
g_clear_object(&loader);
return FALSE;
}
return TRUE;
}
static gboolean
gplugin_lua_unload(
G_GNUC_UNUSED GPluginPlugin *plugin,
gboolean shutdown,
GError **error)
{
GPluginManager *manager = NULL;
gboolean ret = FALSE;
if(!shutdown) {
g_set_error_literal(
error,
GPLUGIN_DOMAIN,
0,
_("The Lua loader can not be unloaded"));
return FALSE;
}
manager = gplugin_manager_get_default();
ret = gplugin_manager_unregister_loader(manager, loader, error);
g_clear_object(&loader);
return ret;
}
GPLUGIN_NATIVE_PLUGIN_DECLARE(gplugin_lua)