gplugin/gplugin

fix memory leaks in gplugin_file_source

15 months ago, Markus Fischer
d821f171d4c6
fix memory leaks in gplugin_file_source

leaks encountered:
## libpurple test_contact_info and test_person
```
==5998== 16 bytes in 1 blocks are definitely lost in loss record 1,996 of 6,277
==5998== at 0x48417E4: malloc (vg_replace_malloc.c:393)
==5998== by 0x4A6FA18: g_malloc (in /usr/lib64/libglib-2.0.so.0.7400.4)
==5998== by 0x4A88540: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.7400.4)
==5998== by 0x4A89675: g_slist_prepend (in /usr/lib64/libglib-2.0.so.0.7400.4)
==5998== by 0x4F0DA9E: gplugin_file_source_add_loader (gplugin-file-source.c:112)
==5998== by 0x4F0DCF1: gplugin_file_source_update_loaders (gplugin-file-source.c:179)
==5998== by 0x4F0E971: gplugin_file_source_constructed (gplugin-file-source.c:524)
==5998== by 0x49CF002: ??? (in /usr/lib64/libgobject-2.0.so.0.7400.4)
==5998== by 0x49D0C33: g_object_new_valist (in /usr/lib64/libgobject-2.0.so.0.7400.4)
==5998== by 0x49D1250: g_object_new (in /usr/lib64/libgobject-2.0.so.0.7400.4)
==5998== by 0x4F0EC51: gplugin_file_source_new (gplugin-file-source.c:607)
==5998== by 0x4F08019: gplugin_manager_refresh (gplugin-manager.c:874)
```
## gplugin tests
```
==23357== 456 (16 direct, 440 indirect) bytes in 1 blocks are definitely lost in loss record 535 of 557
==23357== at 0x48417E4: malloc (vg_replace_malloc.c:393)
==23357== by 0x48E4828: g_malloc (in /usr/lib64/libglib-2.0.so.0.7400.5)
==23357== by 0x48FD281: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.7400.5)
==23357== by 0x48FE6A8: g_slist_copy_deep (in /usr/lib64/libglib-2.0.so.0.7400.5)
==23357== by 0x485B252: gplugin_manager_find_plugins (gplugin-manager.c:934)
==23357== by 0x4861216: gplugin_file_source_scan (gplugin-file-source.c:349)
==23357== by 0x48622A9: gplugin_source_scan (gplugin-source.c:66)
==23357== by 0x485B041: gplugin_manager_refresh (gplugin-manager.c:881)
==23357== by 0x109464: test_gplugin_init_uninit_with_double_refresh_plugins (test-core.c:115)
==23357== by 0x49079DD: ??? (in /usr/lib64/libglib-2.0.so.0.7400.5)
==23357== by 0x490774C: ??? (in /usr/lib64/libglib-2.0.so.0.7400.5)
==23357== by 0x4907EE1: g_test_run_suite (in /usr/lib64/libglib-2.0.so.0.7400.5)
```

Testing Done:
Ran all gplugin tests and test_contact_info and test_person from libpurple in valgrind without encountering above leaks or any invalid reads/writes.

Reviewed at https://reviews.imfreedom.org/r/2255/
/*
* Copyright (C) 2011-2014 Gary Kramlich <grim@reaperworld.com>
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, see <https://www.gnu.org/licenses/>.
*/
#include <gplugin.h>
/******************************************************************************
* Tests
*****************************************************************************/
/* bad versions */
static void
test_gplugin_version_null__null(void)
{
g_assert_cmpint(gplugin_version_compare(NULL, NULL), ==, 0);
}
static void
test_gplugin_version_null__1_2_3(void)
{
g_assert_cmpint(gplugin_version_compare(NULL, "1.2.3"), <, 0);
}
static void
test_gplugin_version_1_2_3__null(void)
{
g_assert_cmpint(gplugin_version_compare("1.2.3", NULL), >, 0);
}
static void
test_gplugin_version_abc__1_2_3(void)
{
g_assert_cmpint(gplugin_version_compare("abc", "1.2.3"), <, 0);
}
static void
test_gplugin_version_1_2_3__abc(void)
{
g_assert_cmpint(gplugin_version_compare("1.2.3", "abc"), >, 0);
}
/* major version tests */
static void
test_gplugin_version_1_0_0__0_0_0(void)
{
g_assert_cmpint(gplugin_version_compare("1.0.0", "0.0.0"), >, 0);
}
static void
test_gplugin_version_1_0_0__1_0_0(void)
{
g_assert_cmpint(gplugin_version_compare("1.0.0", "1.0.0"), ==, 0);
}
static void
test_gplugin_version_0_0_0__1_0_0(void)
{
g_assert_cmpint(gplugin_version_compare("0.0.0", "1.0.0"), <, 0);
}
/* minor version tests */
static void
test_gplugin_version_0_1_0__0_0_0(void)
{
g_assert_cmpint(gplugin_version_compare("0.1.0", "0.0.0"), >, 0);
}
static void
test_gplugin_version_0_1_0__0_1_0(void)
{
g_assert_cmpint(gplugin_version_compare("0.1.0", "0.1.0"), ==, 0);
}
static void
test_gplugin_version_0_0_0__0_1_0(void)
{
g_assert_cmpint(gplugin_version_compare("0.0.0", "0.1.0"), <, 0);
}
/* micro version tests */
static void
test_gplugin_version_0_0_1__0_0_0(void)
{
g_assert_cmpint(gplugin_version_compare("0.0.1", "0.0.0"), >, 0);
}
static void
test_gplugin_version_0_0_1__0_0_1(void)
{
g_assert_cmpint(gplugin_version_compare("0.0.1", "0.0.1"), ==, 0);
}
static void
test_gplugin_version_0_0_0__0_0_1(void)
{
g_assert_cmpint(gplugin_version_compare("0.0.0", "0.0.1"), <, 0);
}
/* major-minor tests */
static void
test_gplugin_version_1_0__0_1(void)
{
g_assert_cmpint(gplugin_version_compare("1.0", "0.1"), >, 0);
}
static void
test_gplugin_version_1_0__1_0(void)
{
g_assert_cmpint(gplugin_version_compare("1.0", "1.0"), ==, 0);
}
static void
test_gplugin_version_0_1__1_0(void)
{
g_assert_cmpint(gplugin_version_compare("0.1", "1.0"), <, 0);
}
/* major tests */
static void
test_gplugin_version_1__0(void)
{
g_assert_cmpint(gplugin_version_compare("1", "0"), >, 0);
}
static void
test_gplugin_version_1__1(void)
{
g_assert_cmpint(gplugin_version_compare("1", "1"), ==, 0);
}
static void
test_gplugin_version_0__1(void)
{
g_assert_cmpint(gplugin_version_compare("0", "1"), <, 0);
}
/******************************************************************************
* Main
*****************************************************************************/
gint
main(gint argc, gchar **argv)
{
g_test_init(&argc, &argv, G_TEST_OPTION_ISOLATE_DIRS, NULL);
gplugin_init(GPLUGIN_CORE_FLAGS_NONE);
/* bad versions */
g_test_add_func(
"/version-compare/null__null",
test_gplugin_version_null__null);
g_test_add_func(
"/version-compare/null__1_2_3",
test_gplugin_version_null__1_2_3);
g_test_add_func(
"/version-compare/1_2_3__null",
test_gplugin_version_1_2_3__null);
g_test_add_func(
"/version-compare/abc__1_2_3",
test_gplugin_version_abc__1_2_3);
g_test_add_func(
"/version-compare/1_2_3__abc",
test_gplugin_version_1_2_3__abc);
/* major version */
g_test_add_func(
"/version-compare/1_0_0__0_0_0",
test_gplugin_version_1_0_0__0_0_0);
g_test_add_func(
"/version-compare/1_0_0__1_0_0",
test_gplugin_version_1_0_0__1_0_0);
g_test_add_func(
"/version-compare/0_0_0__1_0_0",
test_gplugin_version_0_0_0__1_0_0);
/* minor version */
g_test_add_func(
"/version-compare/0_1_0__0_0_0",
test_gplugin_version_0_1_0__0_0_0);
g_test_add_func(
"/version-compare/0_1_0__0_1_0",
test_gplugin_version_0_1_0__0_1_0);
g_test_add_func(
"/version-compare/0_0_0__0_1_0",
test_gplugin_version_0_0_0__0_1_0);
/* micro version */
g_test_add_func(
"/version-compare/0_0_1__0_0_0",
test_gplugin_version_0_0_1__0_0_0);
g_test_add_func(
"/version-compare/0_0_1__0_0_1",
test_gplugin_version_0_0_1__0_0_1);
g_test_add_func(
"/version-compare/0_0_0__0_0_1",
test_gplugin_version_0_0_0__0_0_1);
/* major-minor */
g_test_add_func("/version-compare/1_0__0_1", test_gplugin_version_1_0__0_1);
g_test_add_func("/version-compare/1_0__1_0", test_gplugin_version_1_0__1_0);
g_test_add_func("/version-compare/0_1__1_0", test_gplugin_version_0_1__1_0);
/* major */
g_test_add_func("/version-compare/1__0", test_gplugin_version_1__0);
g_test_add_func("/version-compare/1__1", test_gplugin_version_1__1);
g_test_add_func("/version-compare/0__1", test_gplugin_version_0__1);
return g_test_run();
}