gplugin/gplugin

fix memory leaks in gplugin_file_source

15 months ago, Markus Fischer
d821f171d4c6
fix memory leaks in gplugin_file_source

leaks encountered:
## libpurple test_contact_info and test_person
```
==5998== 16 bytes in 1 blocks are definitely lost in loss record 1,996 of 6,277
==5998== at 0x48417E4: malloc (vg_replace_malloc.c:393)
==5998== by 0x4A6FA18: g_malloc (in /usr/lib64/libglib-2.0.so.0.7400.4)
==5998== by 0x4A88540: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.7400.4)
==5998== by 0x4A89675: g_slist_prepend (in /usr/lib64/libglib-2.0.so.0.7400.4)
==5998== by 0x4F0DA9E: gplugin_file_source_add_loader (gplugin-file-source.c:112)
==5998== by 0x4F0DCF1: gplugin_file_source_update_loaders (gplugin-file-source.c:179)
==5998== by 0x4F0E971: gplugin_file_source_constructed (gplugin-file-source.c:524)
==5998== by 0x49CF002: ??? (in /usr/lib64/libgobject-2.0.so.0.7400.4)
==5998== by 0x49D0C33: g_object_new_valist (in /usr/lib64/libgobject-2.0.so.0.7400.4)
==5998== by 0x49D1250: g_object_new (in /usr/lib64/libgobject-2.0.so.0.7400.4)
==5998== by 0x4F0EC51: gplugin_file_source_new (gplugin-file-source.c:607)
==5998== by 0x4F08019: gplugin_manager_refresh (gplugin-manager.c:874)
```
## gplugin tests
```
==23357== 456 (16 direct, 440 indirect) bytes in 1 blocks are definitely lost in loss record 535 of 557
==23357== at 0x48417E4: malloc (vg_replace_malloc.c:393)
==23357== by 0x48E4828: g_malloc (in /usr/lib64/libglib-2.0.so.0.7400.5)
==23357== by 0x48FD281: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.7400.5)
==23357== by 0x48FE6A8: g_slist_copy_deep (in /usr/lib64/libglib-2.0.so.0.7400.5)
==23357== by 0x485B252: gplugin_manager_find_plugins (gplugin-manager.c:934)
==23357== by 0x4861216: gplugin_file_source_scan (gplugin-file-source.c:349)
==23357== by 0x48622A9: gplugin_source_scan (gplugin-source.c:66)
==23357== by 0x485B041: gplugin_manager_refresh (gplugin-manager.c:881)
==23357== by 0x109464: test_gplugin_init_uninit_with_double_refresh_plugins (test-core.c:115)
==23357== by 0x49079DD: ??? (in /usr/lib64/libglib-2.0.so.0.7400.5)
==23357== by 0x490774C: ??? (in /usr/lib64/libglib-2.0.so.0.7400.5)
==23357== by 0x4907EE1: g_test_run_suite (in /usr/lib64/libglib-2.0.so.0.7400.5)
```

Testing Done:
Ran all gplugin tests and test_contact_info and test_person from libpurple in valgrind without encountering above leaks or any invalid reads/writes.

Reviewed at https://reviews.imfreedom.org/r/2255/
/*
* Copyright (C) 2011-2020 Gary Kramlich <grim@reaperworld.com>
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, see <https://www.gnu.org/licenses/>.
*/
#include <glib.h>
#include <gplugin.h>
/******************************************************************************
* Helpers
*****************************************************************************/
static void
test_gplugin_manager_foreach_load_plugins(
G_GNUC_UNUSED const gchar *id,
GSList *plugins,
G_GNUC_UNUSED gpointer data)
{
GPluginManager *manager = gplugin_manager_get_default();
GSList *l = NULL;
for(l = plugins; l != NULL; l = l->next) {
gplugin_manager_load_plugin(manager, GPLUGIN_PLUGIN(l->data), NULL);
}
}
static void
test_gplugin_manager_foreach_unload_plugins(
G_GNUC_UNUSED const gchar *id,
GSList *plugins,
G_GNUC_UNUSED gpointer data)
{
GPluginManager *manager = gplugin_manager_get_default();
GSList *l = NULL;
for(l = plugins; l != NULL; l = l->next) {
gplugin_manager_unload_plugin(manager, GPLUGIN_PLUGIN(l->data), NULL);
}
}
/******************************************************************************
* Tests
*****************************************************************************/
/*< private >
* test_gplugin_manager_find_plugins_with_state:
*
* Runs through the normal plugins in the plugins directory, trying to progress
* their state each iteration while checking that
* gplugin_manager_find_plugins_with_state() returns the correct values.
*
* If any changes are made to the plugins directory, this test will need to be
* updated.
*/
static void
test_gplugin_manager_find_plugins_with_state(void)
{
GPluginManager *manager = NULL;
GSList *plugins = NULL;
/* this is the list of the current plugins and the furthest state they can
* make it in the plugin lifecycle:
*
* basic-plugin.c: unloaded
* broken-dependent-plugin.c: queried
* dependent-plugin.c: queried
* load-exception: load failed
* load-failed: load failed
* unload-failed: unload failed
*/
gint QUERIED = 7;
gint LOADED = 3;
gint LOAD_FAILED = 2;
gint UNLOADED = 3; /* unloaded plugins go back to the queried state */
gint UNLOAD_FAILED = 2;
gplugin_init(GPLUGIN_CORE_FLAGS_NONE);
manager = gplugin_manager_get_default();
gplugin_manager_append_path(manager, TEST_DIR);
gplugin_manager_refresh(manager);
/* make sure that all the plugins are queried */
plugins = gplugin_manager_find_plugins_with_state(
manager,
GPLUGIN_PLUGIN_STATE_QUERIED);
g_assert_cmpint(g_slist_length(plugins), ==, QUERIED);
g_slist_free_full(plugins, g_object_unref);
/* now load all of the plugins */
gplugin_manager_foreach(
manager,
test_gplugin_manager_foreach_load_plugins,
NULL);
/* make sure we have the proper number loaded */
plugins = gplugin_manager_find_plugins_with_state(
manager,
GPLUGIN_PLUGIN_STATE_LOADED);
g_assert_cmpint(g_slist_length(plugins), ==, LOADED);
g_slist_free_full(plugins, g_object_unref);
/* make sure we have the proper number of load failed */
plugins = gplugin_manager_find_plugins_with_state(
manager,
GPLUGIN_PLUGIN_STATE_LOAD_FAILED);
g_assert_cmpint(g_slist_length(plugins), ==, LOAD_FAILED);
g_slist_free_full(plugins, g_object_unref);
/* unload all of the plugins */
gplugin_manager_foreach(
manager,
test_gplugin_manager_foreach_unload_plugins,
NULL);
/* make sure we have the proper number unloaded */
plugins = gplugin_manager_find_plugins_with_state(
manager,
GPLUGIN_PLUGIN_STATE_QUERIED);
g_assert_cmpint(g_slist_length(plugins), ==, UNLOADED);
g_slist_free_full(plugins, g_object_unref);
/* make sure we have the proper number of unload failed */
plugins = gplugin_manager_find_plugins_with_state(
manager,
GPLUGIN_PLUGIN_STATE_UNLOAD_FAILED);
g_assert_cmpint(g_slist_length(plugins), ==, UNLOAD_FAILED);
g_slist_free_full(plugins, g_object_unref);
gplugin_uninit();
}
/******************************************************************************
* Main
*****************************************************************************/
gint
main(gint argc, gchar **argv)
{
g_test_init(&argc, &argv, G_TEST_OPTION_ISOLATE_DIRS, NULL);
g_test_add_func(
"/manager/find_plugins/with_state",
test_gplugin_manager_find_plugins_with_state);
return g_test_run();
}