HGKeeper

fix memory leaks in gplugin_file_source

14 months ago, Markus Fischer

d821f171d4c6

fix memory leaks in gplugin_file_source

leaks encountered:
## libpurple test_contact_info and test_person
```
==5998== 16 bytes in 1 blocks are definitely lost in loss record 1,996 of 6,277
==5998== at 0x48417E4: malloc (vg_replace_malloc.c:393)
==5998== by 0x4A6FA18: g_malloc (in /usr/lib64/libglib-2.0.so.0.7400.4)
==5998== by 0x4A88540: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.7400.4)
==5998== by 0x4A89675: g_slist_prepend (in /usr/lib64/libglib-2.0.so.0.7400.4)
==5998== by 0x4F0DA9E: gplugin_file_source_add_loader (gplugin-file-source.c:112)
==5998== by 0x4F0DCF1: gplugin_file_source_update_loaders (gplugin-file-source.c:179)
==5998== by 0x4F0E971: gplugin_file_source_constructed (gplugin-file-source.c:524)
==5998== by 0x49CF002: ??? (in /usr/lib64/libgobject-2.0.so.0.7400.4)
==5998== by 0x49D0C33: g_object_new_valist (in /usr/lib64/libgobject-2.0.so.0.7400.4)
==5998== by 0x49D1250: g_object_new (in /usr/lib64/libgobject-2.0.so.0.7400.4)
==5998== by 0x4F0EC51: gplugin_file_source_new (gplugin-file-source.c:607)
==5998== by 0x4F08019: gplugin_manager_refresh (gplugin-manager.c:874)
```
## gplugin tests
```
==23357== 456 (16 direct, 440 indirect) bytes in 1 blocks are definitely lost in loss record 535 of 557
==23357== at 0x48417E4: malloc (vg_replace_malloc.c:393)
==23357== by 0x48E4828: g_malloc (in /usr/lib64/libglib-2.0.so.0.7400.5)
==23357== by 0x48FD281: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.7400.5)
==23357== by 0x48FE6A8: g_slist_copy_deep (in /usr/lib64/libglib-2.0.so.0.7400.5)
==23357== by 0x485B252: gplugin_manager_find_plugins (gplugin-manager.c:934)
==23357== by 0x4861216: gplugin_file_source_scan (gplugin-file-source.c:349)
==23357== by 0x48622A9: gplugin_source_scan (gplugin-source.c:66)
==23357== by 0x485B041: gplugin_manager_refresh (gplugin-manager.c:881)
==23357== by 0x109464: test_gplugin_init_uninit_with_double_refresh_plugins (test-core.c:115)
==23357== by 0x49079DD: ??? (in /usr/lib64/libglib-2.0.so.0.7400.5)
==23357== by 0x490774C: ??? (in /usr/lib64/libglib-2.0.so.0.7400.5)
==23357== by 0x4907EE1: g_test_run_suite (in /usr/lib64/libglib-2.0.so.0.7400.5)
```

Testing Done:
Ran all gplugin tests and test_contact_info and test_person from libpurple in valgrind without encountering above leaks or any invalid reads/writes.

Reviewed at https://reviews.imfreedom.org/r/2255/

* This library is free software; you can redistribute it and/or

* modify it under the terms of the GNU Lesser General Public

* License as published by the Free Software Foundation; either

* version 2 of the License, or (at your option) any later version.

* This library is distributed in the hope that it will be useful,

* but WITHOUT ANY WARRANTY; without even the implied warranty of

* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU

* Lesser General Public License for more details.

* You should have received a copy of the GNU Lesser General Public

* License along with this library; if not, see <https://www.gnu.org/licenses/>.

#if !defined(GPLUGIN_GLOBAL_HEADER_INSIDE) && !defined(GPLUGIN_COMPILATION)

#error "only <gplugin.h> may be included directly"

#endif

#ifndef GPLUGIN_PLUGIN_H

#define GPLUGIN_PLUGIN_H

#include <glib.h>

#include <glib-object.h>

/* clang-format off */

typedef enum /*< prefix=GPLUGIN_PLUGIN_STATE,underscore_name=GPLUGIN_PLUGIN_STATE >*/ {

GPLUGIN_PLUGIN_STATE_UNKNOWN = -1,

GPLUGIN_PLUGIN_STATE_ERROR = 0,

GPLUGIN_PLUGIN_STATE_QUERIED,

GPLUGIN_PLUGIN_STATE_REQUERY,

GPLUGIN_PLUGIN_STATE_LOADED,

GPLUGIN_PLUGIN_STATE_LOAD_FAILED,

GPLUGIN_PLUGIN_STATE_UNLOAD_FAILED,

/*< private >*/

GPLUGIN_PLUGIN_STATES, /*< skip >*/

} GPluginPluginState;

/* clang-format on */

G_BEGIN_DECLS

#define GPLUGIN_TYPE_PLUGIN (gplugin_plugin_get_type())

G_DECLARE_INTERFACE(GPluginPlugin, gplugin_plugin, GPLUGIN, PLUGIN, GObject)

/* circular dependencies suck... */

#include <gplugin/gplugin-loader.h>

#include <gplugin/gplugin-plugin-info.h>

struct _GPluginPluginInterface {

/*< private >*/

GTypeInterface parent;

/*< public >*/

void (*state_changed)(

GPluginPlugin *plugin,

GPluginPluginState oldstate,

GPluginPluginState newstate);

/*< private >*/

gpointer reserved[8];

};

gchar *gplugin_plugin_get_filename(GPluginPlugin *plugin);

GPluginLoader *gplugin_plugin_get_loader(GPluginPlugin *plugin);

GPluginPluginInfo *gplugin_plugin_get_info(GPluginPlugin *plugin);

GPluginPluginState gplugin_plugin_get_state(GPluginPlugin *plugin);

void gplugin_plugin_set_state(GPluginPlugin *plugin, GPluginPluginState state);

GPluginPluginState gplugin_plugin_get_desired_state(GPluginPlugin *plugin);

void gplugin_plugin_set_desired_state(

GPluginPlugin *plugin,

GPluginPluginState state);

GError *gplugin_plugin_get_error(GPluginPlugin *plugin);

const gchar *gplugin_plugin_state_to_string(GPluginPluginState state);

G_END_DECLS

#endif /* GPLUGIN_PLUGIN_H */