gplugin/gplugin

fix memory leaks in gplugin_file_source

14 months ago, Markus Fischer
d821f171d4c6
fix memory leaks in gplugin_file_source

leaks encountered:
## libpurple test_contact_info and test_person
```
==5998== 16 bytes in 1 blocks are definitely lost in loss record 1,996 of 6,277
==5998== at 0x48417E4: malloc (vg_replace_malloc.c:393)
==5998== by 0x4A6FA18: g_malloc (in /usr/lib64/libglib-2.0.so.0.7400.4)
==5998== by 0x4A88540: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.7400.4)
==5998== by 0x4A89675: g_slist_prepend (in /usr/lib64/libglib-2.0.so.0.7400.4)
==5998== by 0x4F0DA9E: gplugin_file_source_add_loader (gplugin-file-source.c:112)
==5998== by 0x4F0DCF1: gplugin_file_source_update_loaders (gplugin-file-source.c:179)
==5998== by 0x4F0E971: gplugin_file_source_constructed (gplugin-file-source.c:524)
==5998== by 0x49CF002: ??? (in /usr/lib64/libgobject-2.0.so.0.7400.4)
==5998== by 0x49D0C33: g_object_new_valist (in /usr/lib64/libgobject-2.0.so.0.7400.4)
==5998== by 0x49D1250: g_object_new (in /usr/lib64/libgobject-2.0.so.0.7400.4)
==5998== by 0x4F0EC51: gplugin_file_source_new (gplugin-file-source.c:607)
==5998== by 0x4F08019: gplugin_manager_refresh (gplugin-manager.c:874)
```
## gplugin tests
```
==23357== 456 (16 direct, 440 indirect) bytes in 1 blocks are definitely lost in loss record 535 of 557
==23357== at 0x48417E4: malloc (vg_replace_malloc.c:393)
==23357== by 0x48E4828: g_malloc (in /usr/lib64/libglib-2.0.so.0.7400.5)
==23357== by 0x48FD281: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.7400.5)
==23357== by 0x48FE6A8: g_slist_copy_deep (in /usr/lib64/libglib-2.0.so.0.7400.5)
==23357== by 0x485B252: gplugin_manager_find_plugins (gplugin-manager.c:934)
==23357== by 0x4861216: gplugin_file_source_scan (gplugin-file-source.c:349)
==23357== by 0x48622A9: gplugin_source_scan (gplugin-source.c:66)
==23357== by 0x485B041: gplugin_manager_refresh (gplugin-manager.c:881)
==23357== by 0x109464: test_gplugin_init_uninit_with_double_refresh_plugins (test-core.c:115)
==23357== by 0x49079DD: ??? (in /usr/lib64/libglib-2.0.so.0.7400.5)
==23357== by 0x490774C: ??? (in /usr/lib64/libglib-2.0.so.0.7400.5)
==23357== by 0x4907EE1: g_test_run_suite (in /usr/lib64/libglib-2.0.so.0.7400.5)
```

Testing Done:
Ran all gplugin tests and test_contact_info and test_person from libpurple in valgrind without encountering above leaks or any invalid reads/writes.

Reviewed at https://reviews.imfreedom.org/r/2255/
environment:
- BUILD_NUMBER
- REPOSITORY=gplugin/builders
- REGISTRY=docker.io
- REGISTRY_USERNAME
- REGISTRY_PASSWORD
- DOCS_BUILD_IMAGE=${REGISTRY}/${REPOSITORY}:debian-bookworm-amd64
tasks:
clean:
type: convey/clean
files:
- alpine-edge-amd64
- debian-bookworm-amd64
- debian-bookworm-arm64
- debian-bookworm-armhf
- dist
- fedora-36-amd64
- fedora-rawhide-amd64
- i18n
- opensuse-tumbleweed-amd64
- scanbuild
- ubuntu-jammy-amd64
- valgrind
- gplugin-docs
- gplugin-gtk4-docs
import:
type: docker/import
files: .:.
import-artifacts:
type: docker/import
files: ${DISTRO}-${VERSION}-${ARCH}
build:
type: docker/run
image: ${REGISTRY}/${REPOSITORY}:${TARGET}
export:
type: docker/export
files: ${TARGET}
login:
type: docker/login
server: ${REGISTRY}
username: ${REGISTRY_USERNAME}
password: ${REGISTRY_PASSWORD}
logout:
type: docker/logout
server: ${REGISTRY}
docs-clean:
type: convey/clean
files:
- gplugin-docs
- gplugin-gtk-docs
docs-build:
type: docker/run
image: ${DOCS_BUILD_IMAGE}
workdir: ${CONVEY_WORKSPACE}
script:
- set -ex
- meson build-docs
- ninja -C build-docs doc
docs-export:
type: docker/export
files:
- build-docs/gplugin/reference/gplugin:gplugin-docs
- build-docs/gplugin-gtk4/reference/gplugin-gtk4:gplugin-gtk4-docs
plans:
clean:
stages:
- tasks: clean
alpine-edge-amd64:
environment: TARGET=alpine-edge-amd64
stages:
- tasks: [import, build]
- tasks: [export]
run: always
clang-format:
environment: TARGET=clang-format
stages:
- tasks: [import, build]
debian-bookworm-amd64:
environment: TARGET=debian-bookworm-amd64
stages:
- tasks: [import, build]
- tasks: [export]
run: always
debian-bookworm-arm64:
environment: TARGET=debian-bookworm-arm64
stages:
- tasks: [import, build]
- tasks: [export]
run: always
debian-bookworm-armhf:
environment: TARGET=debian-bookworm-armhf
stages:
- tasks: [import, build]
- tasks: [export]
run: always
dist:
environment: TARGET=dist
stages:
- tasks: [import, build]
- tasks: [export]
run: always
docs:
stages:
- tasks: [docs-clean, import, docs-build, docs-export]
fedora-36-amd64:
environment: TARGET=fedora-36-amd64
stages:
- tasks: [import, build]
- tasks: [export]
run: always
fedora-rawhide-amd64:
environment: TARGET=fedora-rawhide-amd64
stages:
- tasks: [import, build]
- tasks: [export]
run: always
i18n:
environment: TARGET=i18n
stages:
- tasks: [import, build]
- tasks: [export]
run: always
opensuse-tumbleweed-amd64:
environment: TARGET=opensuse-tumbleweed-amd64
stages:
- tasks: [import, build]
- tasks: [export]
run: always
scanbuild:
environment: TARGET=scanbuild
stages:
- tasks: [import, build]
- tasks: [export]
run: always
simple:
environment: TARGET=simple
stages:
- tasks: [import, build]
- tasks: [export]
run: always
ubuntu-jammy-amd64:
environment: TARGET=ubuntu-jammy-amd64
stages:
- tasks: [import, build]
- tasks: [export]
run: always
valgrind:
environment: TARGET=valgrind
stages:
- tasks: [import, build]
- tasks: [export]
run: always
meta-plans:
all:
plans:
- alpine-edge-amd64
- debian-bookworm-amd64
- dist
- fedora-34-amd64
- fedora-rawhide-amd64
- opensuse-tumbleweed-amd64
- ubuntu-jammy-amd64
tools:
plans:
- clang-format
- i18n
- scanbuild
- valgrind
- simple
qemu-user-static:
plans:
- debian-bookworm-arm64
- debian-bookworm-armhf