gaim/gaim

sf bug #1166027, from Giacomo Rizzo and Peter Ajamian
oldstatus
2005-03-20, Mark Doliner
bbcbfc9a0503
Parents e9c4a90913ef
Children 95f3d3a229ee
sf bug #1166027, from Giacomo Rizzo and Peter Ajamian
Gaim v1.2.0 ICQ login fails when password is greater than 8
characters. These guys narrowed down the problem and provided
a patch. Yay for users.
3 files changed, 16 insertions(+), 1 deletions(-)
  • +1 -0
    COPYRIGHT
  • +2 -0
    ChangeLog
  • +13 -1
    src/protocols/oscar/auth.c
    • --- a/COPYRIGHT Sun Mar 20 21:25:48 2005 -0500
    +++ b/COPYRIGHT Sun Mar 20 21:55:37 2005 -0500
    @@ -4,6 +4,7 @@
    If you have contributed to Gaim, you deserve to be on this list.
    Contact us (see: AUTHORS) and we'll add you.
    +Peter Ajamian
    Daniel Atallah
    Paul Aurich
    Patrick Aussems
    --- a/ChangeLog Sun Mar 20 21:25:48 2005 -0500
    +++ b/ChangeLog Sun Mar 20 21:55:37 2005 -0500
    @@ -3,6 +3,8 @@
    version 1.2.1:
    * URL escaping now works with UTF-8 text. This may break some old log
    files.
    + * Fix signing on ICQ accounts with passwords greater than 8 characters
    + (Peter Ajamian)
    version 1.2.0 (3/17/2005):
    * Yahoo file receiving and buddy icon receiving work again.
    --- a/src/protocols/oscar/auth.c Sun Mar 20 21:25:48 2005 -0500
    +++ b/src/protocols/oscar/auth.c Sun Mar 20 21:55:37 2005 -0500
    @@ -230,7 +230,19 @@
    aim_tlvlist_add_raw(&tl, 0x0001, strlen(sn), sn);
    - aim_encode_password_md5(password, key, digest);
    + /* Truncated ICQ passwords, if necessary */
    + if (isdigit(sn[0]) && (strlen(password) > MAXICQPASSLEN))
    + {
    + char truncated[MAXICQPASSLEN + 1];
    + strncpy(truncated, password, MAXICQPASSLEN);
    + truncated[MAXICQPASSLEN] = 0;
    + aim_encode_password_md5(truncated, key, digest);
    + }
    + else
    + {
    + aim_encode_password_md5(password, key, digest);
    + }
    +
    aim_tlvlist_add_raw(&tl, 0x0025, 16, digest);
    #ifndef USE_OLD_MD5