adium/adium

Most ESTextAndButtonsWindowController run independently: after calling -show, -release should not be called, as they'll release themselves when they're done.
adium-1.5.2
2012-06-11, Thijs Alkemade
d78e9b1cdc69
Parents b9d9c8a21067
Children 122e8edb9c89
Most ESTextAndButtonsWindowController run independently: after calling -show, -release should not be called, as they'll release themselves when they're done.

Fix GBQuestionHandlerPlugin to adhere to that, so it doesn't crash when finishing.

Fixes #15900
1 files changed, 2 insertions(+), 1 deletions(-)
  • +2 -1
    Source/GBQuestionHandlerPlugin.m
    • --- a/Source/GBQuestionHandlerPlugin.m Fri Jun 08 13:17:40 2012 +0200
    +++ b/Source/GBQuestionHandlerPlugin.m Mon Jun 11 11:17:12 2012 +0200
    @@ -105,7 +105,8 @@
    ret = NO;
    else
    {
    - [currentAlert release];
    + // Note: Explicitly not released here: ESTextAndButtonsWindowController will autorelease itself in -windowWillClose:
    + [currentAlert close];
    currentAlert = nil;
    }
    return ret;