adium/adium

Fixed 3 "Call to free data when error was returned during allocation" in AIKeychain. Analyzer Warnings--.

2012-01-29, Adrian Godoroja
0016b375a750
Parents c0ad36313b1f
Children 1012b2cbbfaa
Fixed 3 "Call to free data when error was returned during allocation" in AIKeychain. Analyzer Warnings--.
1 files changed, 11 insertions(+), 5 deletions(-)
  • +11 -5
    Frameworks/AIUtilities Framework/Source/AIKeychain.m
    • --- a/Frameworks/AIUtilities Framework/Source/AIKeychain.m Sat Jan 28 22:43:36 2012 +0200
    +++ b/Frameworks/AIUtilities Framework/Source/AIKeychain.m Sun Jan 29 00:27:00 2012 +0200
    @@ -809,8 +809,11 @@
    }
    passwordString = [NSString stringWithBytes:passwordData length:passwordLength encoding:NSUTF8StringEncoding];
    - SecKeychainItemFreeContent(NULL, passwordData);
    -
    +
    + if (err == noErr) {
    + SecKeychainItemFreeContent(NULL, passwordData);
    + }
    +
    return passwordString;
    }
    @@ -893,12 +896,12 @@
    username, @"Username",
    password, @"Password",
    nil];
    +
    + SecKeychainItemFreeAttributesAndData(attrList, passwordBytes);
    } else {
    NSLog(@"Error extracting infomation from keychain item");
    }
    - SecKeychainItemFreeAttributesAndData(attrList, passwordBytes);
    -
    if (item) {
    CFRelease(item);
    }
    @@ -1221,7 +1224,10 @@
    }
    passwordString = [NSString stringWithBytes:passwordData length:passwordLength encoding:NSUTF8StringEncoding];
    - SecKeychainItemFreeContent(NULL, passwordData);
    +
    + if (err == noErr) {
    + SecKeychainItemFreeContent(NULL, passwordData);
    + }
    return passwordString;
    }