adium/adium

Transition Adium from SenTestingKit to XCTest.

2015-12-14, Matthew Kotila
334dc418b409
Transition Adium from SenTestingKit to XCTest.

In order to build on OS X 10.11, Xcode 7.2, several changes have been made that are outlined:
- Unit tests Target Build Settings modified:
* 'Wrapper Extension' set to 'xctest'
* 'Enable Modules (C and Objective-C)' set to 'Yes'
- UnitTests Target of AutoHyperlink.framework Build Settings modified:
* 'Wrapper Extension' set to 'xctest'
* 'Enable Modules (C and Objective-C)' set to 'Yes'
* 'Other Linker Flags' removed '-framework SenTestingKit'
- 'SenTestingKit.framework' removed from Adium -> Linked Frameworks -> System
- 'SenTestingKit.framework' removed from Adium -> Linked Frameworks -> AutoHyperlinks.framework.xcodeproj -> External Frameworks and Libraries -> Linked Frameworks
- Find and Replace within 'Adium/Unit tests' && 'Adium/Linked Frameworks/Others/AutoHyperlinks.framework.xcodeproj/UnitTests'
* '' to ''
* 'SenTestCase' to 'XCTestCase'
* 'STAssert' to 'XCTAssert'
* 'XCTAssertEquals(' to 'XCTAssertEqual('
* regex '(\[\[\[)([^\]]*\][^\]]*\])(\ autorelease\]);' to '[[$2;'
* regex '(\[)([^\]]*\][^\]]*)(\ autorelease\])' to '$2'
- modified AutoHyperlinks.framework.xcodeproj -> project.pbxproj
* line 331: ’productType = "com.apple.product-type.bundle.ocunit-test";' to 'productType = "com.apple.product-type.bundle.unit-test";'
- AIWebKitMessageViewController.h
* forward declare WebUIDelegate, WebFrameLoadDelegate protocols
* add WebUIDelegate, WebFrameLoadDelegate protocols to 'AIWebKitMessageViewController' class
- AIFacebookXMPPOAuthWebViewWindowController.m lines 107 && 108
* '[[domDoc getElementById:@"email"] setValue:self.autoFillUsername];' to '[domDoc getElementById:@"email"].innerHTML = self.autoFillUsername;'
* '[[domDoc getElementById:@"pass"] setValue:self.autoFillPassword];' to '[domDoc getElementById:@"pass"].innerHTML = self.autoFillPassword;'
- XCTAssertEqual for NSRanges modified to ’XCTAssertTrue(NSEqualRanges(range1, range2)), ...)' in Unit tests
/*
* Adium is the legal property of its developers, whose names are listed in the copyright file included
* with this source distribution.
*
* This program is free software; you can redistribute it and/or modify it under the terms of the GNU
* General Public License as published by the Free Software Foundation; either version 2 of the License,
* or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even
* the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General
* Public License for more details.
*
* You should have received a copy of the GNU General Public License along with this program; if not,
* write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
*/
#import "AdiumApplescriptRunner.h"
@implementation AdiumApplescriptRunner
- (void)dealloc
{
if (applescriptRunner) {
xpc_connection_cancel(applescriptRunner);
applescriptRunner = NULL;
}
}
/*!
* @brief Run an applescript, optinally calling a function with arguments, and notify a target/selector with its output when it is done
*/
- (void)runApplescriptAtPath:(NSString *)path function:(NSString *)function arguments:(NSArray *)arguments notifyingTarget:(id)target selector:(SEL)selector userInfo:(id)userInfo
{
if (!applescriptRunner) {
applescriptRunner = xpc_connection_create("im.adium.AIApplescriptRunner", NULL);
xpc_connection_set_event_handler(applescriptRunner, ^(xpc_object_t obj){
AILogWithSignature(@"Received something.");
xpc_type_t type = xpc_get_type(obj);
if (type == XPC_TYPE_ERROR) {
AILogWithSignature(@"Received an error");
if (obj == XPC_ERROR_CONNECTION_INVALID) {
AILogWithSignature(@"Our connection terminated!");
} else if (obj == XPC_ERROR_CONNECTION_INTERRUPTED) {
AILogWithSignature(@"Our connection was interrupted!");
}
}
});
xpc_connection_resume(applescriptRunner);
}
xpc_object_t obj = xpc_dictionary_create(NULL, NULL, 0);
xpc_dictionary_set_string(obj, "path", [path UTF8String]);
xpc_dictionary_set_string(obj, "function", (function ? [function UTF8String] : ""));
xpc_object_t array = xpc_array_create(NULL, 0);
for (NSString *argument in arguments) {
xpc_object_t argObject = xpc_string_create([argument UTF8String]);
xpc_array_set_value(array, XPC_ARRAY_APPEND, argObject);
#if MAC_OS_X_VERSION_MIN_REQUIRED <= MAC_OS_X_VERSION_10_7
xpc_release(argObject);
#endif
}
xpc_dictionary_set_value(obj, "arguments", array);
#if MAC_OS_X_VERSION_MIN_REQUIRED <= MAC_OS_X_VERSION_10_7
xpc_release(array);
#endif
xpc_connection_send_message_with_reply(applescriptRunner, obj, dispatch_get_main_queue(), ^(xpc_object_t reply){
if (target && selector) {
const char *resultStr = xpc_dictionary_get_string(reply, "result");
NSString *result = (resultStr ? [NSString stringWithUTF8String:resultStr] : @"");
[target performSelector:selector withObject:userInfo withObject:result];
}
});
#if MAC_OS_X_VERSION_MIN_REQUIRED <= MAC_OS_X_VERSION_10_7
xpc_release(obj);
#endif
}
@end