adium/adium

Transition Adium from SenTestingKit to XCTest.

2015-12-14, Matthew Kotila
334dc418b409
Transition Adium from SenTestingKit to XCTest.

In order to build on OS X 10.11, Xcode 7.2, several changes have been made that are outlined:
- Unit tests Target Build Settings modified:
* 'Wrapper Extension' set to 'xctest'
* 'Enable Modules (C and Objective-C)' set to 'Yes'
- UnitTests Target of AutoHyperlink.framework Build Settings modified:
* 'Wrapper Extension' set to 'xctest'
* 'Enable Modules (C and Objective-C)' set to 'Yes'
* 'Other Linker Flags' removed '-framework SenTestingKit'
- 'SenTestingKit.framework' removed from Adium -> Linked Frameworks -> System
- 'SenTestingKit.framework' removed from Adium -> Linked Frameworks -> AutoHyperlinks.framework.xcodeproj -> External Frameworks and Libraries -> Linked Frameworks
- Find and Replace within 'Adium/Unit tests' && 'Adium/Linked Frameworks/Others/AutoHyperlinks.framework.xcodeproj/UnitTests'
* '' to ''
* 'SenTestCase' to 'XCTestCase'
* 'STAssert' to 'XCTAssert'
* 'XCTAssertEquals(' to 'XCTAssertEqual('
* regex '(\[\[\[)([^\]]*\][^\]]*\])(\ autorelease\]);' to '[[$2;'
* regex '(\[)([^\]]*\][^\]]*)(\ autorelease\])' to '$2'
- modified AutoHyperlinks.framework.xcodeproj -> project.pbxproj
* line 331: ’productType = "com.apple.product-type.bundle.ocunit-test";' to 'productType = "com.apple.product-type.bundle.unit-test";'
- AIWebKitMessageViewController.h
* forward declare WebUIDelegate, WebFrameLoadDelegate protocols
* add WebUIDelegate, WebFrameLoadDelegate protocols to 'AIWebKitMessageViewController' class
- AIFacebookXMPPOAuthWebViewWindowController.m lines 107 && 108
* '[[domDoc getElementById:@"email"] setValue:self.autoFillUsername];' to '[domDoc getElementById:@"email"].innerHTML = self.autoFillUsername;'
* '[[domDoc getElementById:@"pass"] setValue:self.autoFillPassword];' to '[domDoc getElementById:@"pass"].innerHTML = self.autoFillPassword;'
- XCTAssertEqual for NSRanges modified to ’XCTAssertTrue(NSEqualRanges(range1, range2)), ...)' in Unit tests
/*
* Adium is the legal property of its developers, whose names are listed in the copyright file included
* with this source distribution.
*
* This program is free software; you can redistribute it and/or modify it under the terms of the GNU
* General Public License as published by the Free Software Foundation; either version 2 of the License,
* or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even
* the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General
* Public License for more details.
*
* You should have received a copy of the GNU General Public License along with this program; if not,
* write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
*/
#import "AIPasswordPromptController.h"
#import <objc/objc-runtime.h>
#define PASSWORD_PROMPT_NIB @"PasswordPrompt"
#define KEY_PASSWORD_WINDOW_FRAME @"Password Prompt Frame"
@interface AIPasswordPromptController ()
- (void)setPassword:(NSString *)password;
@end
@implementation AIPasswordPromptController
- (id)initWithWindowNibName:(NSString *)windowNibName password:(NSString *)inPassword notifyingTarget:(id)inTarget selector:(SEL)inSelector context:(id)inContext
{
if ((self = [super initWithWindowNibName:windowNibName])) {
[self setTarget:inTarget selector:inSelector context:inContext];
[self setPassword:inPassword];
}
return self;
}
- (void)setTarget:(id)inTarget selector:(SEL)inSelector context:(id)inContext
{
if (inTarget != target) {
target = inTarget;
}
selector = inSelector;
if (inContext != context) {
context = inContext;
}
}
- (void)setPassword:(NSString *)inPassword
{
if (password != inPassword) {
password = [inPassword copy];
}
}
- (void)windowDidLoad
{
[[self window] center];
[textField_password setStringValue:(password ? password : @"")];
[super windowDidLoad];
}
- (NSString *)savedPasswordKey
{
return nil;
}
- (IBAction)cancel:(id)sender
{
//close up and notify our caller (pass nil to signify no password)
[self closeWindow:nil];
void (*targetMethodSender)(id, SEL, id, AIPasswordPromptReturn, id) = (void (*)(id, SEL, id, AIPasswordPromptReturn, id)) objc_msgSend;
targetMethodSender(target, selector, nil, AIPasswordPromptCancelReturn, context);
}
- (IBAction)okay:(id)sender
{
NSString *thePassword = [textField_password stringValue];
BOOL savePassword = [checkBox_savePassword state];
//save password?
if (savePassword && thePassword && [thePassword length]) {
[self savePassword:thePassword];
}
//close up and notify our caller
[self closeWindow:nil];
void (*targetMethodSender)(id, SEL, id, AIPasswordPromptReturn, id) = (void (*)(id, SEL, id, AIPasswordPromptReturn, id)) objc_msgSend;
targetMethodSender(target, selector, thePassword, AIPasswordPromptOKReturn, context);
}
- (IBAction)togglePasswordSaved:(id)sender
{
if ([sender state] == NSOffState) {
//Forget any saved passwords
[self savePassword:nil];
}
}
- (void)savePassword:(NSString *)password
{
//abstract method. subclasses can do things here.
}
- (void)textDidChange:(NSNotification *)notification
{
//if the password field is empty, disable the OK button.
//otherwise, enable it.
[button_OK setEnabled:([[textField_password stringValue] length] != 0)];
}
// called as the window closes
- (void)windowWillClose:(id)sender
{
[NSObject cancelPreviousPerformRequestsWithTarget:[self window]
selector:@selector(makeFirstResponder:)
object:textField_password];
[super windowWillClose:sender];
}
- (void)windowDidBecomeKey:(NSNotification *)aNotification
{
[[self window] performSelector:@selector(makeFirstResponder:)
withObject:textField_password
afterDelay:0];
}
- (BOOL)shouldResignKeyWindowWithoutUserInput
{
/* We override this to ensure that password windows
* don't have their focus pulled away programmatically.
*/
return NO;
}
@end